feat: add message_id to Email model - #113
Conversation
- Add message_id field to Email model for GET /emails/:id and list responses - Add typed webhook event payload models with message_id in BaseEmailEventData and ReceivedEmailEventData, matching the Node.js SDK structure - Update Webhooks.verify() to return the parsed WebhookEventPayload - Add email.scheduled and email.suppressed to WebhookEvent enum Co-authored-by: cpenned <cpenned@users.noreply.github.com>
Remove webhook event payload models, verify() return type change, and WebhookEvent enum additions. Keep only message_id on Email for GET /emails/:id and list responses. Co-authored-by: cpenned <cpenned@users.noreply.github.com>
There was a problem hiding this comment.
0 issues found across 33 files (changes from recent commits).
Auto-approved: Adds a new message_id field to the Email model with getter/setter and updates the test to verify deserialization. No logic or API changes, low risk.
Re-trigger cubic
Co-authored-by: cpenned <cpenned@users.noreply.github.com>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: Adds a field to the Email model and updates a test. No logic changes, low risk.
Re-trigger cubic
Co-authored-by: cpenned <cpenned@users.noreply.github.com>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: Adds a new field to a model class with corresponding tests. Low risk, no logic changes.
Re-trigger cubic
hermesresend
left a comment
There was a problem hiding this comment.
LGTM — standard getter/setter pattern matching the rest of the model, test asserts the parsed value.
Summary
Adds
message_idto theEmailmodel forGET /emails/:idand list responses, matching the Node.js SDK.Changes
message_idfield toEmailwithgetMessageId()/setMessageId()EmailsTestto verify deserializationUsage
Summary by cubic
Add
message_idto theEmailmodel for GET/emails/:idand list responses so you can correlate messages across systems.Emailmodel: addedmessage_idwithgetMessageId()/setMessageId(); Javadoc aligned; tests updated with example111-222-333@email.example.com.Written for commit e137411. Summary will update on new commits.