feat: custom click tracking#92
Merged
kewynakshlley merged 2 commits intomainfrom Apr 9, 2026
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
rehanvdm
reviewed
Apr 9, 2026
Contributor
rehanvdm
left a comment
rehanvdm
left a comment
There was a problem hiding this comment.
Thanks, just checking that:
- Are these new fields all optional? I believe they are, but I want to double-check
- We don't have tests for the Java package?
…main field with tests
Collaborator
Author
|
@rehanvdm good catch, thanks! Now all new fields are optional. I fixed UpdateDomainOptions to use Boolean instead of primitive boolean on openTracking and clickTracking and I added trackingSubdomain to the tests. |
rehanvdm
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.