Skip to content

feat(domains): add TrackingCAA record support#199

Merged
drish merged 2 commits intomainfrom
feat/tracking-caa-record
Apr 15, 2026
Merged

feat(domains): add TrackingCAA record support#199
drish merged 2 commits intomainfrom
feat/tracking-caa-record

Conversation

@rehanvdm
Copy link
Copy Markdown
Contributor

@rehanvdm rehanvdm commented Apr 15, 2026

Summary

The Domains API now returns an extra DNS record on POST /domains and GET /domains/:id when a tracking subdomain is configured and the customer's root domain has CAA records that would prevent AWS from issuing a certificate for the tracking subdomain:

{
  "record": "TrackingCAA",
  "name": "",
  "type": "CAA",
  "ttl": "Auto",
  "value": "0 issue \"amazon.com\"",
  "status": "verified"
}

The Record TypedDict already accepts arbitrary string values for record and type, so no source change is required beyond a docstring update — the record deserializes today. This PR extends the test fixtures (sync + async) so the new record is exercised, and updates the docstring to list TrackingCAA as a known example value.

Test plan

  • pytest tests/domains_test.py tests/domains_async_test.py — 32 passed (including the new TrackingCAA assertions in test_domains_create_with_tracking_subdomain, test_domains_get_with_tracking_fields, and their async equivalents)

Tracking: Linear ENG-4843

🤖 Generated with Claude Code


Summary by cubic

Adds TrackingCAA DNS record support in domain responses when a tracking subdomain is set and root-domain CAA would block AWS from issuing the tracking certificate. Aligns with Linear ENG-4843.

  • New Features

    • Updated Record docstring to include TrackingCAA.
    • Extended sync and async tests to cover the new CAA record (value: 0 issue "amazon.com") and ensure it deserializes correctly.
  • Dependencies

    • Bumped resend version to 2.28.1.

Written for commit 86d23b3. Summary will update on new commits.

The Domains API now returns an extra DNS record `TrackingCAA` (type
`CAA`, value `0 issue "amazon.com"`) when a `tracking_subdomain` is
configured AND the customer's root domain has CAA records that would
prevent AWS from issuing the tracking-domain certificate.

Updates the Record docstring to list `TrackingCAA` as an example value
and extends the create/get domain test fixtures (sync + async) to
include the new record.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@drish drish merged commit 54a412e into main Apr 15, 2026
19 checks passed
@drish drish deleted the feat/tracking-caa-record branch April 15, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants