feat(domains): add TrackingCAA record support#199
Merged
Conversation
The Domains API now returns an extra DNS record `TrackingCAA` (type `CAA`, value `0 issue "amazon.com"`) when a `tracking_subdomain` is configured AND the customer's root domain has CAA records that would prevent AWS from issuing the tracking-domain certificate. Updates the Record docstring to list `TrackingCAA` as an example value and extends the create/get domain test fixtures (sync + async) to include the new record. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
drish
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Domains API now returns an extra DNS record on
POST /domainsandGET /domains/:idwhen a tracking subdomain is configured and the customer's root domain has CAA records that would prevent AWS from issuing a certificate for the tracking subdomain:{ "record": "TrackingCAA", "name": "", "type": "CAA", "ttl": "Auto", "value": "0 issue \"amazon.com\"", "status": "verified" }The
RecordTypedDict already accepts arbitrary string values forrecordandtype, so no source change is required beyond a docstring update — the record deserializes today. This PR extends the test fixtures (sync + async) so the new record is exercised, and updates the docstring to listTrackingCAAas a known example value.Test plan
pytest tests/domains_test.py tests/domains_async_test.py— 32 passed (including the newTrackingCAAassertions intest_domains_create_with_tracking_subdomain,test_domains_get_with_tracking_fields, and their async equivalents)Tracking: Linear ENG-4843
🤖 Generated with Claude Code
Summary by cubic
Adds
TrackingCAADNS record support in domain responses when a tracking subdomain is set and root-domain CAA would block AWS from issuing the tracking certificate. Aligns with Linear ENG-4843.New Features
Recorddocstring to includeTrackingCAA.CAArecord (value: 0 issue "amazon.com") and ensure it deserializes correctly.Dependencies
resendversion to 2.28.1.Written for commit 86d23b3. Summary will update on new commits.