feat(domains): add TrackingCAA record support#170
Merged
Conversation
The Domains API now returns an extra DNS record `TrackingCAA` (type `CAA`, value `0 issue "amazon.com"`) when a `tracking_subdomain` is configured AND the customer's root domain has CAA records that would prevent AWS from issuing the tracking-domain certificate. Records are returned as plain hashes in this SDK so no source change is needed — extends the create-with-tracking-subdomain spec with the new record fixture. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 4/5
- This PR looks safe to merge overall, with limited runtime risk since the flagged change is in tests (
spec/domains_spec.rb) rather than production code. - The main issue is concrete: new assertions access nested
recordswith symbol keys, but parsed nested response data is typically string-keyed, which can cause misleading spec failures or incorrect test coverage. - Pay close attention to
spec/domains_spec.rb- update nestedrecordsassertions to use string keys so tests reflect real parsed response structures.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="spec/domains_spec.rb">
<violation number="1" location="spec/domains_spec.rb:139">
P2: Access nested `records` fields with string keys in these new assertions; symbol keys here don't reflect real parsed responses.
(Based on your team's feedback about nested arrays/hashes using string keys.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
drish
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Domains API now returns an extra DNS record on
POST /domainsandGET /domains/:idwhen a tracking subdomain is configured and the customer's root domain has CAA records that would prevent AWS from issuing a certificate for the tracking subdomain:{ "record": "TrackingCAA", "name": "", "type": "CAA", "ttl": "Auto", "value": "0 issue \"amazon.com\"", "status": "verified" }Records are returned as plain hashes in this SDK, so no source change is required — the record deserializes today. This PR extends the existing
creates a domain with tracking_subdomainspec to include and assert on the new record.Test plan
bundle exec rspec(local Ruby is older than the project minimum, so deferring to CI)Tracking: Linear ENG-4844
🤖 Generated with Claude Code
Summary by cubic
Adds support for returning a
TrackingCAADNS record when a tracking subdomain is set and the root domain’s CAA would block AWS from issuing the tracking certificate. Updates the tracking subdomain spec to cover this case (per Linear ENG-4844).POST /domainsandGET /domains/:idmay include aTrackingCAArecord withtype: "CAA",value: "0 issue \"amazon.com\"", andttl: "Auto".Written for commit fcc21f0. Summary will update on new commits.