feat(receiving): add html_format query param to get#185
Merged
Conversation
gabrielmfern
approved these changes
Jun 16, 2026
Contributor
There was a problem hiding this comment.
2 issues found across 2 files
Confidence score: 4/5
- In
lib/resend/emails/receiving.rb, usingPaginationHelper.build_paginated_pathforhtml_formatcreates a semantic mismatch that could fail if the helper later enforces pagination-only params, causing email-receiving URLs to break unexpectedly — switch to a format-specific path builder or appendhtml_formatseparately before merging. - In
spec/emails/receiving_spec.rb, a test description still uses “should,” which can violate suite conventions and trigger lint/CI friction even though runtime behavior is unaffected — rename the example text to match the no-should style before merging to keep the test suite clean and consistent.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
drish
force-pushed
the
feat/receiving-html-format-param
branch
from
June 16, 2026 18:59
0be34c6 to
34702ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add support for an optional
html_formatquery param on receiving email GET requests to control HTML content format. No breaking changes; existing calls still work.Resend::Emails::Receiving.get(id, params = {})acceptshtml_format(e.g., "sanitized", "raw") and URL-encodes it into the query.html_format=sanitizedis sent and the response is handled correctly.Written for commit 34702ec. Summary will update on new commits.