Skip to content

feat(receiving): add html_format query param to get#185

Merged
drish merged 1 commit into
mainfrom
feat/receiving-html-format-param
Jun 16, 2026
Merged

feat(receiving): add html_format query param to get#185
drish merged 1 commit into
mainfrom
feat/receiving-html-format-param

Conversation

@drish

@drish drish commented Jun 16, 2026

Copy link
Copy Markdown
Member

Summary by cubic

Add support for an optional html_format query param on receiving email GET requests to control HTML content format. No breaking changes; existing calls still work.

  • New Features
    • Resend::Emails::Receiving.get(id, params = {}) accepts html_format (e.g., "sanitized", "raw") and URL-encodes it into the query.
    • Spec verifies html_format=sanitized is sent and the response is handled correctly.

Written for commit 34702ec. Summary will update on new commits.

Review in cubic

@drish
drish requested a review from gabrielmfern June 16, 2026 18:48

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 2 files

Confidence score: 4/5

  • In lib/resend/emails/receiving.rb, using PaginationHelper.build_paginated_path for html_format creates a semantic mismatch that could fail if the helper later enforces pagination-only params, causing email-receiving URLs to break unexpectedly — switch to a format-specific path builder or append html_format separately before merging.
  • In spec/emails/receiving_spec.rb, a test description still uses “should,” which can violate suite conventions and trigger lint/CI friction even though runtime behavior is unaffected — rename the example text to match the no-should style before merging to keep the test suite clean and consistent.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread lib/resend/emails/receiving.rb Outdated
Comment thread spec/emails/receiving_spec.rb
@drish
drish force-pushed the feat/receiving-html-format-param branch from 0be34c6 to 34702ec Compare June 16, 2026 18:59
@drish
drish merged commit e45e717 into main Jun 16, 2026
9 checks passed
@drish
drish deleted the feat/receiving-html-format-param branch June 16, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants