test: assert message_id on email responses#196
Merged
Conversation
Add RBS type signatures matching the Node.js SDK for message_id on GET /emails/:id, receiving email responses, and all email webhook events. Include sig files in the gem package, stop gitignoring sig/, and update specs to assert message_id. Co-authored-by: cpenned <cpenned@users.noreply.github.com>
cpenned
marked this pull request as ready for review
July 8, 2026 19:03
Revert the broad RBS webhook/email type definitions, gemspec sig packaging, gitignore change, and doc comments. The API already returns message_id; keep only the spec updates that assert it. Co-authored-by: cpenned <cpenned@users.noreply.github.com>
cursor
Bot
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
0 issues found across 11 files (changes from recent commits).
Auto-approved: Test-only changes asserting message_id in email responses and updating fixtures.
Re-trigger cubic
drish
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scoped down to only cover the new
message_idfield. The Ruby SDK already returns API fields as hashes — no runtime or RBS changes are needed.Changes
message_idinGET /emails/:idspecmessage_idin list emails fixturemessage_idin received email get spec (fixture already had the field)Removed from earlier draft
Reverted the broad RBS type definitions, gemspec/gitignore changes, and YARD comments that went beyond
message_id.Summary by cubic
Add test assertions for
message_idon email responses to ensure the field is present inGET /emails/:id, received email, and list responses. Scoped to test coverage only; reverted prior RBS/packaging/docs changes with no runtime changes.Written for commit e93f1d8. Summary will update on new commits.