Add custom filter to toggle specialist - #128
Merged
Merged
Conversation
aclerc
commented
Jul 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a caller-configurable row-exclusion mechanism to the toggle-specialist baseline so certain test-turbine operating modes can be removed from timestamp selection (alongside existing downtime/availability filtering), with a diagnostic plot to make exclusions visible.
Changes:
- Extend
ColumnSchemawith an optionalexclude_rowrole describing a caller-provided boolean exclusion column. - Update
ToggleSpecialistMethodtimestamp selection to drop test-turbine rows flagged byexclude_row. - Add an “excluded rows” diagnostic plot showing excluded vs kept points and daily exclusion fraction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| benchmarking/synthetic/schema.py | Adds the optional exclude_row schema role and documents its intended semantics/constraints. |
| benchmarking/baselines/toggle_specialist.py | Applies exclude_row during used-mask construction (test turbine only) and writes a diagnostics plot for excluded rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.