Concurrency configurability and fail-fast on fatal errors - #25
Closed
tangym wants to merge 2 commits into
Closed
Conversation
Previously, judge reused rollout.concurrency and seeds hardcoded concurrency=8. Each stage now has its own configurable concurrency: - pipeline.judge.concurrency (default: 10) - pipeline.seeds.concurrency (default: 8) Defaults preserve existing behavior. Rollout concurrency is unchanged.
When an LLMAuthError or LLMInputError hits one task, all remaining tasks are now cancelled immediately. These errors (bad API key, invalid request) cannot succeed on retry, so continuing wastes API budget. Transient errors (LLMRateLimitError, LLMProviderError) are unaffected and still collected without cancelling peers.
|
@tangym please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Collaborator
|
closing for hygiene, reopen if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds independent concurrency configuration for judge and seeds stages, and implements fail-fast cancellation when fatal LLM errors are detected.
Changes
1. Independent concurrency per stage
Previously, judge reused
rollout.concurrencyand seeds hardcoded concurrency to 8. Each stage now has its own YAML key:pipeline.judge.concurrency(default: 10)pipeline.seeds.concurrency(default: 8)Defaults preserve existing behavior. Example:
2. Fail-fast on fatal LLM errors
When an
LLMAuthErrororLLMInputErrorhits one task in rollout or judge, all remaining tasks are now cancelled immediately. These errors (bad API key, invalid request) cannot succeed on retry, so continuing wastes API budget.Transient errors (
LLMRateLimitError,LLMProviderError) are unaffected and still collected without cancelling peers.Also fixed
build_run_viewer_artifactsto guard against missing transcripts file when all seeds fail.Testing
LLMAuthError)