feat(node-ci): optional runner input for self-hosted runners - #38
Merged
Conversation
New optional input 'runner' (default ubuntu-latest) sets runs-on, so a caller can route the reusable node CI onto a self-hosted runner (e.g. when GitHub-hosted minutes are exhausted) by passing runner: self-hosted. Backward-compatible: omitting it keeps ubuntu-latest, so every existing consumer is unchanged.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe reusable Node CI workflow adds a ChangesNode CI runner configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
WomB0ComB0
added a commit
that referenced
this pull request
Jul 30, 2026
…ers (#39) Mirrors node-ci.yml's `runner` input (#38). All 9 scan jobs (vet, codeql, gitleaks, osv, dependency-review, snyk, semgrep, zizmor, actionlint) were hardcoded to `ubuntu-latest`; when GitHub-hosted runners are unavailable (exhausted minutes) every scan fails with no runner assigned. Adds a `runner` string input (default `ubuntu-latest`, fully backward compatible — existing callers are unchanged) and switches every job to `runs-on: ${{ inputs.runner }}`. Callers on self-hosted infra pass `runner: self-hosted`. harden-runner stays in `egress-policy: audit` on every job, which is self-hosted-safe (monitors rather than blocks).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
runnerinput (defaultubuntu-latest) to the reusablenode-ci.yml, so a caller can route the job onto a self-hosted runner viarunner: self-hosted.Backward-compatible — omitting the input keeps
ubuntu-latest, so every existing consumer is unchanged.Why: when GitHub-hosted Actions minutes are exhausted org-wide, every hosted job fails at startup (zero steps). A self-hosted runner sidesteps that. Consumers wire the input to a repo/org variable (e.g.
runner: ${{ vars.CI_RUNS_ON || 'ubuntu-latest' }}) so it toggles without editing workflows.Consumed by
resq-software/research(see its companionci/self-hosted-runner-optionPR). Same pattern can extend tosecurity-scan.ymlas a follow-up.Summary by CodeRabbit