chore(deps): consolidate dependency bumps (supersedes #37/#38/#39/#40/#41) - #43
Conversation
…41) All five open Dependabot PRs edit the same Directory.Packages.props, so they conflict with each other by construction: #38 was already DIRTY and the other four sat BEHIND. Merging any one re-breaks the rest. Folding them into a single change follows the precedent set by #34. MinVer 6.0.0 -> 7.0.0 (#37) Polly.Core 8.5.0 -> 8.7.0 (#38) Scalar.AspNetCore 2.0.5 -> 2.16.20 (#39) Microsoft.EntityFrameworkCore 9.0.0 -> 9.0.19 (#40) Microsoft.EntityFrameworkCore.Rel. 9.0.0 -> 9.0.19 (#40) Microsoft.Extensions.Http.Resilience 9.0.0 -> 9.10.0 (#40) Microsoft.AspNetCore.Mvc.Testing 9.0.0 -> 9.0.19 (#40) Meziantou.Analyzer 3.0.157 -> 3.0.159 (#41) Everything stays inside the holds configured in dependabot.yml: the Microsoft.* moves are all within the 9.x line, so the >=10.0.0 hold is respected, and FluentAssertions is untouched. Two bumps warranted more than a version check. MinVer 6 -> 7 is a major with a [BREAKING] "switch to System.CommandLine" entry, but that changes minver-cli argument parsing. We never invoke the CLI (no minver-cli / dotnet minver anywhere in the repo); we consume the MSBuild task via PackageReference with PrivateAssets="all" plus a MinVerTagPrefix property, neither of which the rework touches. Socket's -32 supply-chain score was raised on #37 and is answered in detail there: Socket's blocking alert check passes, vulnerability/quality/maintenance/ license all stay 100, provenance is byte-identical (same author, same Apache-2.0, same adamralph/minver), and both versions declare zero NuGet dependencies, so there is no new transitive surface. Scalar.AspNetCore jumps 16 minors, but our entire surface is one Development-only MapScalarApiReference() call. Verified locally on .NET SDK 10.0.110: restore clean, Release build succeeded with 0 warnings / 0 errors (worth noting given the analyzer bump), and dotnet pack exercised MinVer 7 end to end, which derived a version and produced .nupkg + .snupkg. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Audit passed with minor recommendations. See full report below. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
PR Audit SummaryI have audited the dependency consolidation in this PR. The changes are generally sound, but there are a few minor inconsistencies and maintenance items to address: 1. EF Core Version AlignmentThe building block dependencies (
Recommendation: Align these provider versions in the root 2. Outdated CommentsThe following project files contain XML comments that specifically refer to a "9.0.0 EF Core stack". These are now outdated and should be updated to reflect the new 9.0.19 baseline:
3. Notable Updates
4. SecurityThe transitive security pin for Overall, the consolidation is a good cleanup of the conflicting Dependabot PRs. Addressing the version alignment and comments will make it perfectly consistent. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
All five open Dependabot PRs edit the same
Directory.Packages.props, so they conflict with each other by construction — #38 was alreadyDIRTY, the other four satBEHIND, and merging any one re-breaks the rest. Folding them into a single change, following the precedent set by #34.Everything stays inside the holds in
dependabot.yml: theMicrosoft.*moves are all within the 9.x line so the>=10.0.0hold is respected, andFluentAssertionsis untouched.The two that needed more than a version check
MinVer 6 → 7 is a major carrying a
[BREAKING]"switch to System.CommandLine". That changesminver-cliargument parsing — which we never invoke. Grep finds nominver-cli/dotnet minveranywhere. We consume the MSBuild task:Neither the task path nor
MinVerTagPrefixis touched by the rework. The Socket −32 supply-chain score raised on #37 is answered in full there — short version: Socket's blocking alert check passes, vulnerability/quality/maintenance/license all stay 100, provenance is identical (same author, same Apache-2.0, sameadamralph/minver), and both versions declare zero NuGet dependencies, ruling out new transitive surface.PrivateAssets="all"also means it never reaches consumers ofResQ.BuildingBlocks.*.Scalar.AspNetCore jumps 16 minors, but our entire surface is one Development-only
MapScalarApiReference()call inOpenApiExtensions.cs.Verification
Locally on .NET SDK 10.0.110:
dotnet restore— cleandotnet build -c Release— succeeded, 0 warnings / 0 errors (worth noting given the analyzer bump could have added diagnostics)dotnet pack— exercises MinVer 7 end to end; derived a version and produced.nupkg+.snupkgEach superseded PR was also independently green on CI before consolidation.
After merge
#37, #38, #39, #40, and #41 should be closed as superseded. Dependabot will not reopen them — these versions are now current.
Note
MinVer 8.0.0-rc.1exists (2026-05-14) with its own breaking change ("Fail when default pre-release phase is provided"). Staying on 7.0.0 stable is deliberate; worth revisiting when 8.0.0 ships stable.