Update README with Rails example#1735
Merged
corincerami merged 4 commits intoresque:masterfrom Jul 7, 2021
Merged
Conversation
I know the Rails case is in the wiki, but it took me awhile to figure this out, and in the meantime I was stuck. I even posted a question on stackoverflow: https://stackoverflow.com/questions/65224796/resque-not-failing-an-obviously-buggy-job And one of the users suggested I request this change, as the Rails is pretty popular case for the Resque gem.
iloveitaly
reviewed
Jul 5, 2021
iloveitaly
requested changes
Jul 5, 2021
Contributor
iloveitaly
left a comment
iloveitaly
left a comment
There was a problem hiding this comment.
@karpiu this is great! I think it would fit better as the last section within the "Jobs" header as opposed to right after the intro paragraph:
https://github.com/resque/resque#jobs
Could you move this around and ping me again on the PR?
Contributor
Author
|
Addressed comments @iloveitaly |
corincerami
reviewed
Jul 6, 2021
corincerami
reviewed
Jul 6, 2021
Contributor
Author
|
@chrisccerami done |
Member
|
Thanks a lot @karpiu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know the Rails case is in the wiki, but it took me awhile to figure this out, and in the meantime I was stuck. I even posted a question on stackoverflow:
https://stackoverflow.com/questions/65224796/resque-not-failing-an-obviously-buggy-job
And one of the users suggested I request this change, as the Rails is pretty popular case for the Resque gem.