Avoid terminal classification of transient Admin failures - #3
Merged
Conversation
pcholakov
marked this pull request as ready for review
September 3, 2026 19:47
igalshilman
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small additions, mainly CD safety cleanups.
-P.
Summary
Prevent the service delivery checks from treating every
AdminCallRejectedasa terminal failure, and require the Terraform readiness script to match the
current generation exactly.
AdminCallRejectedincludes transient non-2xx Admin API responses such as5xx errors. Argo CD and Flux now leave that state in progress until it recovers
or reaches their bounded timeout. Conditions that represent a controller error
or a foreign-deployment conflict remain terminal.
Validation
terraform -chdir=terraform/01-foundation validateterraform -chdir=terraform/02-restate validateterraform -chdir=terraform/03-services validateterraform fmt -check -recursive terraformbash -n scripts/wait-restatedeployment.shruby scripts/check_repository.rbThe full validator was not run because OpenTofu is unavailable in the local
environment.
References