Treat invalid HTTP S3 endpoint overrides as a startup configuration error#2858
Merged
Treat invalid HTTP S3 endpoint overrides as a startup configuration error#2858
Conversation
Test Results 7 files ± 0 7 suites ±0 2m 46s ⏱️ - 1m 51s Results for commit e2812be. ± Comparison against base commit 3a84972. This pull request removes 2 tests.♻️ This comment has been updated with latest results. |
…aws-allow-http This is a common Minio configuration snag which results in hard-to-understand errors at runtime. Since this will just not work, and potentially induces a data loss risk, it's better to complain loudly upfront.
pcholakov
force-pushed
the
chore/support-global-aws-env-defaults
branch
from
97118c2 to
e2812be
Compare
pcholakov
changed the title
Contributor
Author
|
I think the test failures have nothing at all to do with the contents of the PR, have retried the failing checks. |
muhamadazmy
approved these changes
Mar 11, 2025
Contributor
muhamadazmy
left a comment
muhamadazmy
left a comment
There was a problem hiding this comment.
LGTM :) +1 for merging
pcholakov
added a commit
that referenced
this pull request
Mar 12, 2025
Fixes an error introduced by #2858 which only recognizes the global AWS_ALLOW_HTTP setting, and not the snapshots/metadata store client-specific config section keys.
Merged
pcholakov
added a commit
that referenced
this pull request
Mar 12, 2025
Fixes a mistake introduced by #2858 which only recognizes the global AWS_ALLOW_HTTP setting, and not the snapshots/metadata store client-specific config section keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's easy to miss a warning in the startup logs; since this could lead to data loss, I thought it's better to complain loudly and stop:
Additionally, this PR also enables some standard AWS SDK environment variables to be used as fallback defaults - see https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html.
It might be useful at some point to propagate the dev/production profile into a hidden field in the
CommonOptionsstruct so that we can make better config decisions on the fly deeper into the server construction. WDYT?