Conversation
Fixes an error introduced by #2858 which only recognizes the global AWS_ALLOW_HTTP setting, and not the snapshots/metadata store client-specific config section keys.
pcholakov
commented
Mar 12, 2025
| .aws_endpoint_url | ||
| .as_ref() | ||
| .or(env_endpoint_url.as_ref()); | ||
| if !env_allow_http.unwrap_or_default() |
Contributor
Author
There was a problem hiding this comment.
This was only considering the fallback value previously.
Contributor
There was a problem hiding this comment.
Ah okay. Sorry i missed this the first time
Contributor
Author
There was a problem hiding this comment.
Entirely my mistake, the variable naming did not make it easy to spot!
muhamadazmy
approved these changes
Mar 12, 2025
Test Results 7 files ± 0 7 suites ±0 2m 49s ⏱️ -34s Results for commit b7536b6. ± Comparison against base commit 62ed07d. This pull request removes 10 and adds 17 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an error introduced by #2858 which only recognizes the global AWS_ALLOW_HTTP setting, and not the snapshots/metadata store client-specific config section keys.
C/f https://github.com/restatedev/e2e-verification-runner/actions/runs/13801005766/job/38603269652