Skip to content

Fix allow-HTTP logic#2889

Merged
pcholakov merged 1 commit intomainfrom
fix/logic-error-allow-insecure-http
Mar 12, 2025
Merged

Fix allow-HTTP logic#2889
pcholakov merged 1 commit intomainfrom
fix/logic-error-allow-insecure-http

Conversation

@pcholakov
Copy link
Copy Markdown
Contributor

@pcholakov pcholakov commented Mar 12, 2025

Fixes an error introduced by #2858 which only recognizes the global AWS_ALLOW_HTTP setting, and not the snapshots/metadata store client-specific config section keys.

C/f https://github.com/restatedev/e2e-verification-runner/actions/runs/13801005766/job/38603269652

Fixes an error introduced by #2858 which only recognizes the global AWS_ALLOW_HTTP setting, and not the snapshots/metadata store client-specific config section keys.
@pcholakov pcholakov requested a review from muhamadazmy March 12, 2025 08:34
@pcholakov pcholakov marked this pull request as ready for review March 12, 2025 08:34
.aws_endpoint_url
.as_ref()
.or(env_endpoint_url.as_ref());
if !env_allow_http.unwrap_or_default()
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only considering the fallback value previously.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay. Sorry i missed this the first time

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entirely my mistake, the variable naming did not make it easy to spot!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2025

Test Results

  7 files  ± 0    7 suites  ±0   2m 49s ⏱️ -34s
 52 tests + 7   51 ✅ + 7  1 💤 ±0  0 ❌ ±0 
213 runs  +39  210 ✅ +39  3 💤 ±0  0 ❌ ±0 

Results for commit b7536b6. ± Comparison against base commit 62ed07d.

This pull request removes 10 and adds 17 tests. Note that renamed tests count towards both.
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[1]
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[2]
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[3]
dev.restate.sdktesting.tests.Ingress ‑ idempotentInvokeVirtualObject(URL, Client)
dev.restate.sdktesting.tests.KafkaIngress ‑ handleEventInCounterService(URL, int, Client)
dev.restate.sdktesting.tests.KafkaIngress ‑ handleEventInEventHandler(URL, int, Client)
dev.restate.sdktesting.tests.KillInvocation ‑ kill(Client, URL)
dev.restate.sdktesting.tests.PrivateService ‑ privateService(URL, Client)
dev.restate.sdktesting.tests.UpgradeWithInFlightInvocation ‑ inFlightInvocation(Client, URL)
dev.restate.sdktesting.tests.UpgradeWithNewInvocation ‑ executesNewInvocationWithLatestServiceRevisions(Client, URL)
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[3]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[3]
dev.restate.sdktesting.tests.Combinators ‑ awakeableOrTimeoutUsingAwakeableTimeoutCommand(Client)
dev.restate.sdktesting.tests.Ingress ‑ idempotentInvokeVirtualObject(URI, Client)
dev.restate.sdktesting.tests.Ingress ‑ rawHandler(Client)
dev.restate.sdktesting.tests.KafkaIngress ‑ handleEventInCounterService(URI, int, Client)
…

♻️ This comment has been updated with latest results.

@pcholakov pcholakov merged commit 3bb510f into main Mar 12, 2025
27 checks passed
@pcholakov pcholakov deleted the fix/logic-error-allow-insecure-http branch March 12, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants