Default to metric (km/h) units - #5
Merged
Merged
Conversation
Local dev (no PRIMARY_UNIT env) now defaults to metric (km/h) instead of mph, matching the deployed config which already sets PRIMARY_UNIT=kmh. The iOS app treats both kph and kmh as metric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the backend's default speed unit to metric so the dashboard shows km/h out of the box, and refreshes the docs screenshot to match.
backend/src/config.ts:primaryUnitnow defaults tokph(wasmph) whenPRIMARY_UNITis unset. This is the local-dev / simulator path.docs/images/dashboard.png: replaced with a fresh simulator capture showing km/h and km (est. range), so the README image reflects the metric default.Why
The deployed Container App already sets
PRIMARY_UNIT=kmhvia Terraform, so production was already metric. Local development (simulator, no env var) fell back tomph, which was inconsistent with the deployed experience. The iOS app treats bothkphandkmhas metric, so this aligns local and cloud on km/h.Architecture impact
None. A default-value change plus a documentation image refresh; no components, data flows, message contracts (
VehicleState), data sources, orinfra/resources changed.Testing
npx tsc --noEmitpasses on the backend.SOURCE=simulator) and confirmed the stream emitsprimaryUnit: kph.