Skip to content

fix: ignore malformed/empty filter entries that carry no nested filters#200

Merged
radu-2026 merged 1 commit into
nextfrom
fix/resource-filter-guard
Jul 14, 2026
Merged

fix: ignore malformed/empty filter entries that carry no nested filters#200
radu-2026 merged 1 commit into
nextfrom
fix/resource-filter-guard

Conversation

@radu-2026

Copy link
Copy Markdown
Contributor

Handle requests which carry filters with no nested filters.

Err:

error: 2026-07-13T16:09:44.265Z: Error caught while processing read request: Cannot read properties of undefined (reading 'map') [{"message":"Cannot read properties of undefined (reading 'map')","stack":"TypeError: Cannot read properties of undefined (reading 'map')\n    at /home/node/resource-srv/node_modules/@restorecommerce/resource-base-interface/src/index.ts:173:34\n    at Array.map (<anonymous>)\n    at toObject (/home/node/resource-srv/node_modules/@restorecommerce/resource-base-interface/src/index.ts:171:49)\n    at gQe.read (/home/node/resource-srv/node_modules/@restorecommerce/resource-base-interface/src/core/ServiceBase.ts:127:48)\n    at gQe.read (/home/node/resource-srv/node_modules/@restorecommerce/resource-srv/src/service.ts:98:26)\n    at processTicksAndRejections (node:internal/process/task_queues:104:5)\n    at Object.unaryMethodHandler [as next] (/home/node/resource-srv/node_modules/nice-grpc/src/server/handleUnaryCall.ts:34:12)\n    at /home/node/resource-srv/node_modules/@restorecommerce/chassis-srv/src/microservice/transport/provider/grpc/middlewares.ts:36:24\n    at metaMiddleware (/home/node/resource-srv/node_modules/@restorecommerce/chassis-srv/src/microservice/transport/provider/grpc/middlewares.ts:99:10)\n    at tracingMiddleware (/home/node/resource-srv/node_modules/@restorecommerce/chassis-srv/src/microservice/transport/provider/grpc/middlewares.ts:20:10)","name":"TypeError"}]

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29314852691

Warning

No base build found for commit d953e4d on next.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 68.398%

Details

  • Patch coverage: 6 of 6 lines across 1 file are fully covered (100%).

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 545
Covered Lines: 414
Line Coverage: 75.96%
Relevant Branches: 379
Covered Branches: 218
Branch Coverage: 57.52%
Branches in Coverage %: Yes
Coverage Strength: 51.42 hits per line

💛 - Coveralls

@radu-2026
radu-2026 merged commit 067b68d into next Jul 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants