Fix RTP wrong-port STUN handling and remove duplicated latching#23
Merged
shenjinti merged 2 commits intorestsend:mainfrom Mar 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR tries to fix rustpbx#117.
Linphone will sending bare STUN Binding Requests to adjacent media ports with no reason. And rustpbx/rustrtc will allocated contiguous caller/callee RTP ports if the os allocate port in order .
Example
if linphone send an Invite, the caller port rtp would be 10000, and the callee rtp will be 10001, since the rtcp_mux is default setted, so the rtcp port of caller now become the 10001. but linphone will ignore the answer, it will still trying send stun to 10001, and the peer of leg b will be latched to the leg a.
This PR changes in
rustrtc: