fix: prevent RTCP from corrupting RTP address latching#24
Merged
shenjinti merged 1 commit intorestsend:mainfrom Mar 30, 2026
Merged
fix: prevent RTCP from corrupting RTP address latching#24shenjinti merged 1 commit intorestsend:mainfrom
shenjinti merged 1 commit intorestsend:mainfrom
Conversation
When the remote peer does not support rtcp-mux, RTCP arrives from a separate port. The latching code treated RTP and RTCP identically, allowing an RTCP source address to override the RTP remote address, causing audio to be sent to the wrong port. - Skip latching on RTCP packets (PT 200-211) when remote_rtcp_addr is set (non-mux mode) - Auto-update rtcp-mux from answer in set_remote_description, fixing the race where the ICE pair callback fires before the answer is stored - Add public update_rtcp_mux_from_remote() for manual override Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yeoleobun
force-pushed
the
fix/rtcp-mux-latching
branch
from
59bf4c9 to
629efcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same bug with #23, but that is caller side, this is the callee side:
RustRTC have rtcp-mux enabled as default, but the answer of microsip is not, so the problems is: