update github.com/cenkalti/backoff v4.0.0, and drop Go < 1.12 #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `go mod tidy` produced a diff, and the `go.sum` file was missing in source control: https://github.com/golang/go/wiki/Modules#should-i-commit-my-gosum-file-as-well-as-my-gomod-file > Should I commit my 'go.sum' file as well as my 'go.mod' file? > > Typically your module's go.sum file should be committed along with your go.mod file Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Go versions 1.12 and below are deprecated. Go 1.12 has only recently been deprecated, so keeping that version for now. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This package now officially requires Go 1.12 and up; older versions of Go are deprecated (including Go 1.12 (but only recently)) so updating should be possible now. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
"apt" is not a valid option in this file, and caching apt packages is not recommended according to the Travis documentation: https://docs.travis-ci.com/user/caching/#things-not-to-cache > The cache’s purpose is to make installing language-specific dependencies > easy and fast, so everything related to tools like Bundler, pip, Composer, > npm, Gradle, Maven, is what should go into the cache. > > Large files that are quick to install but slow to download do not benefit > from caching, as they take as long to download from the cache as from the original source: > > - Android SDKs > - Debian packages > - JDK packages > - Compiled binaries > - Docker images Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
Contributor
Author
|
@CMogilko ptal 🤗 /cc @cquon thought I'd do a PR here (related to my review comments on notaryproject/notary#1537) |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package now provides a Go module, but officially requires Go 1.12 and up; older versions of Go are deprecated (including Go 1.12 (but only recently)) so updating should be possible now.
See individual commits for details