Test cleanup modes #975
Merged
Test cleanup modes #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jake Wagoner <jakewagoneredu@gmail.com>
|
🪓 PR closed, deleted preview. |
JackWilb
requested changes
Dec 3, 2025
Comment on lines
167
to
176
| const oldModes = { | ||
| studyNavigatorEnabled: true, | ||
| analyticsInterfacePubliclyAccessible: true, | ||
| dataCollectionEnabled: true, | ||
| }; | ||
| const cleanedModes = { | ||
| developmentModeEnabled: true, | ||
| dataSharingEnabled: true, | ||
| dataCollectionEnabled: true, | ||
| }; |
Contributor
There was a problem hiding this comment.
Will you also try false, false for the old value, please.
JackWilb
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
No
Give a longer description of what this PR addresses and why it's needed
test cleanup modes from #967
Are there any additional TODOs before this PR is ready to go?
No