Fix parse-duration, serialize-javascript, and uuid CVEs (REV-43) - #39
Merged
Conversation
Clears three Dependabot advisories in the CLI: - parse-duration (CVE-2025-25283, ReDoS): bump 1.1.0 -> ^2.1.6. v2 is ESM-only, so require() yields the module namespace and the parser is `.default`; it returns null (not NaN) for unparseable input, and `?? 0` preserves the pre-v2 behaviour of treating that as 0. Verified byte-identical to v1 across 18 TTL inputs (compound, decimal, empty, garbage). Adds engines: node >=20.19.0, required for require(esm). - serialize-javascript (GHSA-5c6j-r48x-rmvq, RCE/DoS): overridden to ^7.0.5. Transitive via mocha (devDependency), never shipped to consumers; no 6.x patch exists. - uuid (CVE-2026-41907, ReDoS): overridden to ^11.1.1. Transitive via xcode, which has no fixed release; verified compatible with xcode's uuid.v4() usage. Verified: tsc clean; CLI boots (require(esm) OK); xcode.generateUuid() works; npm audit clear for all three. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ashirman
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears three Dependabot advisories in the CLI. Independent of #37 (aab-parser/protobufjs).
parse-duration— CVE-2025-25283 (HIGH, ReDoS)Direct dep, bumped
1.1.0 → ^2.1.6. Only used to parse an access-key--ttlstring incommand-parser.ts.require()yields the namespace and the parser is.default.null(v1 returnedNaN) for unparseable input;?? 0preserves v1'sMath.floor(...) === 0behavior.1h30m, decimals, empty, garbage, negatives).engines: node >=20.19.0, required forrequire(esm). Acceptable: Node 18 is EOL and RN toolchains already need Node 20+.serialize-javascript— GHSA-5c6j-r48x-rmvq (HIGH, RCE/DoS)Transitive via
mocha(devDependency → 6.0.2); never shipped to consumers. No 6.x patch exists, so pinned viaoverridesto^7.0.5(resolves 7.0.7).uuid— CVE-2026-41907 (MODERATE, ReDoS)Transitive via
xcode@3.0.1 → uuid@7.0.3. No fixedxcoderelease exists (npm's only suggestion is a downgrade), so pinned viaoverridesto^11.1.1.uuid.v4()usage —xcode.generateUuid()still produces valid pbxproj IDs.xcodeis a runtime dep, so (like protobufjs in Replace unmaintained aab-parser to clear protobufjs CVEs (REV-36) #37) this override cleans CI/this repo but doesn't reach published-CLI consumers untilxcodeships a fix upstream. uuid is used only to generate v4 IDs here, not parse untrusted input, so the ReDoS isn't reachable in practice.Verification
tscclean; no new lint errors--versionworks →require(esm)OK at load)xcode.generateUuid()works underuuid@11.1.1npm auditclear for all threeNote
The
uuidalert was surfaced under thereact-native-code-push-nextrepo — that repo needs its own separate fix.Closes REV-43.
🤖 Generated with Claude Code