sns support#1
Merged
Merged
Conversation
antonyharfield
approved these changes
Oct 25, 2021
antonyharfield
left a comment
antonyharfield
left a comment
Contributor
There was a problem hiding this comment.
I like the typescript definitions! 💯
topherwhite
pushed a commit
to rfcx/rfcx-api
that referenced
this pull request
May 16, 2026
@rfcx/message-queue gained a 'rabbitmq' client in v1.1.0 (alongside existing 'sqs' and 'sns'). This commit: - Bumps @rfcx/message-queue from ^1.0.8 to github:rfcx/message-queue#1.1.0 (using the git ref because the npm publish workflow needs a token refresh; identical content, can be flipped back to ^1.1.0 once npm registry has it) - Adds env-var-gated branch in common/message-queue/sqs.js and sns.js to pick the backend: MESSAGE_QUEUE_KIND unset (default) | sqs | rabbitmq MESSAGE_QUEUE_KIND_SNS unset (default = sns, or mirrors KIND when rabbitmq) | sqs | rabbitmq When MESSAGE_QUEUE_KIND is unset, behavior is bit-identical to upstream (SQS backend). Production env mirror has no MESSAGE_QUEUE_KIND set, so the deploy is safe. When MESSAGE_QUEUE_KIND=rabbitmq, the broker URL comes from RABBITMQ_URL (or legacy AMQP_URL). The rabbitmq client asserts durable queues with prefetch=1 and ack-on-true / nack-without-requeue semantics — closest match to SQS without a redrive policy. Note: the per-classifier-queue path (tasks/segment-created/ classifier-message-queue/index.js) still hardcodes 'sqs' because its downstream consumers are external Python ML workers we don't manage. Only the events that have in-cluster consumers (segmentCreated, classifierJobFinished into core-tasks) actually traverse the new backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.