Skip to content

Consolidate code to set antenna port and disable amps. - #16

Merged
ZeroChaos- merged 4 commits into
masterfrom
ant-amp-consolidation
Jul 22, 2026
Merged

Consolidate code to set antenna port and disable amps.#16
ZeroChaos- merged 4 commits into
masterfrom
ant-amp-consolidation

Conversation

@dperret

@dperret dperret commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This consolidates the code to set the antenna port and to disable the amps for bladerf devices, rather than having the code duplicated in multiple other places.

@dperret
dperret requested a review from ZeroChaos- July 22, 2026 02:00
ZeroChaos-
ZeroChaos- previously approved these changes Jul 22, 2026

@ZeroChaos- ZeroChaos- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, testing then merging

@ZeroChaos-

Copy link
Copy Markdown
Member

@dperret can you add an example of how to use this to the readme?

@dperret

dperret commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

@dperret can you add an example of how to use this to the readme?

Which part? These functions would only be visible to folks developing challengectl. We could add a separate option to disable all of the amps from a given devices file, but that's not in there at the moment. This pull is just for tidying up the code a bit.

@ZeroChaos-

Copy link
Copy Markdown
Member

@dperret can you add an example of how to use this to the readme?

Which part? These functions would only be visible to folks developing challengectl. We could add a separate option to disable all of the amps from a given devices file, but that's not in there at the moment. This pull is just for tidying up the code a bit.

Just an example of how to set a different tx port. Now that it's not hard coded for our one broken sdr it may be useful to others :-)

@dperret

dperret commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

I added some notes to the readme for it, and another comment to challengectl.py. It's still hardcoded for one of our SDRs, but it should be more clear now where to update things to set a different port.

@ZeroChaos-

Copy link
Copy Markdown
Member

Manually tested and gtg

@ZeroChaos-
ZeroChaos- merged commit a3081bb into master Jul 22, 2026
1 check failed
@ZeroChaos-
ZeroChaos- deleted the ant-amp-consolidation branch July 22, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants