feat: distinguish rich text from plain text and hide no-op plain paste - #53
Merged
Conversation
Text copied with styles now shows its own glyph, keeping the type color untouched so plain text — the bulk of the history — looks unchanged. "Paste as plain text" is offered only when there is formatting to strip. The two use different criteria on purpose: the glyph tracks rtf only, since browsers attach html to plain text as well, while the button also counts html because the writer restores it to the clipboard. Also refreshes rtf/html metadata when an existing item is reactivated: re-copying the same text discarded the new format, leaving the item stuck with whatever the first copy carried.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text copied with styles now shows its own glyph, keeping the type color untouched so plain text — the bulk of the history — looks unchanged. "Paste as plain text" is offered only when there is formatting to strip.
The two use different criteria on purpose: the glyph tracks rtf only, since browsers attach html to plain text as well, while the button also counts html because the writer restores it to the clipboard.
Also refreshes rtf/html metadata when an existing item is reactivated: re-copying the same text discarded the new format, leaving the item stuck with whatever the first copy carried.
close #48