Remove hard-linked AST body in function pointers. - #1114
Merged
Conversation
schungx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard linking a closure's AST function body into the
FnPtrtype causes two issues:The closure body can no longer be optimized. The optimizer actually clones the AST body and optimizes it, but that optimized AST body is never called because Rhai would use the hard-linked non-optimized version instead!
This causes a discrepancy between the AST walker and the Rhai Grain VM (which cannot interpret an AST and thus must go through the normal function resolution procecss).
After this PR, the discrepancy between Rhai AST and Rhai Grain is eliminated. The CI test
a_folded_closure_body_keeps_the_optimizers_answeris also removed.In addition, this PR also fine tunes some inline docs and
READMEentries for the added Rhai Grain stuff.