Increment rules set ops no matter what happens #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coleenquadros
approved these changes
Sep 19, 2023
Contributor
|
Lgtm |
philipgough
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on some useful alerts for the project I stumbled upon the fact that the
obsctl_reloader_prom_rule_sets_totalmetric, described asTotal number of obsctl set operations for monitoringv1 rules.is in fact only counting the operations that succeeded.To facilitate the definition of alerts based on percentage of failures over total rule sets, I propose to always increment
obsctl_reloader_prom_rule_sets_total, even when requests fail.