Skip to content

Increment rules set ops no matter what happens #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipgough merged 1 commit into from
Sep 19, 2023
Merged

Increment rules set ops no matter what happens #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/syncer/obsctlsyncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,8 @@ func (o *ObsctlRulesSyncer) LogsRecordingSet(rules lokiv1.RecordingRuleSpec) err
func (o *ObsctlRulesSyncer) MetricsSet(rules monitoringv1.PrometheusRuleSpec) error {
level.Debug(o.logger).Log("msg", "setting metrics for tenant")
fc, currentTenant, err := fetcher.NewCustomFetcher(o.ctx, o.logger)
o.promRulesSetOps.WithLabelValues(string(currentTenant)).Inc()

if err != nil {
level.Error(o.logger).Log("msg", "getting fetcher client", "error", err)
o.promRulesSetFailures.WithLabelValues(string(currentTenant), "get_fetcher_client").Inc()
Expand Down Expand Up @@ -369,7 +371,6 @@ func (o *ObsctlRulesSyncer) MetricsSet(rules monitoringv1.PrometheusRuleSpec) er
return errors.Newf("non-200 status code: %v with empty body", resp.StatusCode())
}

o.promRulesSetOps.WithLabelValues(string(currentTenant)).Inc()
level.Debug(o.logger).Log("msg", string(resp.Body))

return nil
Expand Down