Fix restrictive lifespan value pattern

[jkupferer]

Poolboy supports lifespan values with multiple time unit specifications but the CRDs were preventing this use.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 3c8b0a4a-5ba3-43a1-bbd8-a91535885f96

📥 Commits

Reviewing files that changed from the base of the PR and between d34b118 and d1269c5.

📒 Files selected for processing (6)

• helm/crds/resourceclaims.yaml
• helm/crds/resourcehandles.yaml
• helm/crds/resourcepools.yaml
• helm/templates/crds/resourceclaims.yaml
• helm/templates/crds/resourcehandles.yaml
• helm/templates/crds/resourcepools.yaml

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Relaxed lifespan validation so duration values can now use repeated number-and-unit segments, such as combined time strings.
  • Applied the updated validation rules across resource claims, resource handles, and resource pools for default, maximum, relative maximum, and related lifespan fields.
  • Improved consistency in how lifespan values are accepted by the platform.

Walkthrough

This change updates the OpenAPI schema pattern regex constraints for lifespan duration fields across ResourceClaim, ResourceHandle, and ResourcePool CRDs (source YAMLs and matching Helm templates), broadening validation from a single <number><unit> value to one-or-more repeated <number><unit> segments.

Changes

CRD lifespan pattern updates

Layer / File(s)	Summary
ResourceClaim lifespan pattern helm/crds/resourceclaims.yaml, helm/templates/crds/resourceclaims.yaml	status.lifespan.maximum.maximum and relativeMaximum patterns changed from ^[0-9]+[smhd]$ to ^([0-9]+[smhd])+$.
ResourceHandle lifespan pattern helm/crds/resourcehandles.yaml, helm/templates/crds/resourcehandles.yaml	Adds/updates pattern on spec.lifespan.default, maximum, and relativeMaximum to require one-or-more <number><unit> segments.
ResourcePool lifespan pattern helm/crds/resourcepools.yaml, helm/templates/crds/resourcepools.yaml	spec.lifespan.default, maximum, relativeMaximum, and unclaimed patterns changed from single-segment to repeated ([0-9]+[smhd])+ format.

Estimated code review effort: 2 (Simple) | ~10 minutes

Related issues: None specified.

Related PRs: None specified.

Suggested labels: helm, crd, validation

Suggested reviewers: None specified.

🐰 A hop, a nibble, a regex tweak,
Durations now may chain, unique,
3d2h or 1h30m too,
Poolboy's lifespans, bendy and new.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: loosening lifespan value validation.
Description check	✅ Passed	The description matches the change by noting CRDs blocked multi-unit lifespan values.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jkupferer-remove-pattern-lifespan

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}