Skip to content

fix(cli): main fails the published-JSDoc codename guard — bare issue reference #1589 in netscript-web-runtime-closure.ts #1612

Description

@rickylabs

Summary

main currently fails deno task test. The JSDoc-codename guard shipped by #1554 flags an internal
issue reference in published JSDoc that landed after that guard merged:

packages/cli/src/kernel/domain/dependency-closures/netscript-web-runtime-closure.ts:6
 * runtime. A second fresh-ui instance therefore cannot own the cache-provider singleton in #1589.

Evidence — this is on main, not on a branch

Verified by exporting base 0551ff592 to a clean tree and running the guard there:

$ git archive 0551ff592 | tar -x -C <tmp> && cd <tmp>
$ deno test --allow-all .llm/tools/fitness/check-public-jsdoc-codenames_test.ts
FAILED | 3 passed | 1 failed

git grep "#1589" 0551ff592 -- packages plugins confirms the occurrence is committed on main.

Why this is the guard working, not a false positive

#1554 defines the class as "internal workstream names, wave/epic codenames, and issue numbers in
published JSDoc"
. A bare #1589 in a doc comment is exactly that: it renders on JSR, and a consumer
cannot resolve it — the referenced issue explains nothing to someone outside this repository.

The guard scans published entrypoint closures, and netscript-web-runtime-closure.ts is inside one.
It caught a genuine new occurrence within hours of shipping, which is the outcome it was built for.

Fix

Reword the comment to state the mechanism rather than cite the issue — why a second fresh-ui
instance cannot own the cache-provider singleton, which is the useful half for a reader. If the issue
link has value for maintainers, a backticked reference is ignored by the guard (inline code spans are
stripped), or it belongs in the commit message rather than in published JSDoc.

Boundaries

Acceptance criteria

  • No bare issue reference remains in that file's published JSDoc.
  • deno test .llm/tools/fitness/check-public-jsdoc-codenames_test.ts passes on main.
  • A repo-wide sweep confirms no other occurrence landed in the same window.

Provenance

Found by the 0.0.6 documentation-lane orchestrator while gating PR #1531, by testing whether that
PR's root-test failure reproduced on its base. It did — so the failure belongs to main.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions