PR-B: alpha-1 deprecation-shim removal (breaking, zero-compat)#113
Conversation
…l (breaking) Planning only. Codex implements S1-S3 after PLAN-EVAL PASS.
|
@openhands-agent model=openrouter/minimax/minimax-m3 provider=openrouter output=pr-comment iterations=600 use harness — run PLAN-EVAL (separate-session plan gate) for the alpha-1 deprecation-shim removal run on PR #113 ( This is a planning-only PR. Do NOT implement, delete code, or change framework source. Read the artifacts, verify the manifest against the real surface, apply the plan gate, and emit a verdict comment only. ContextThe NetScript framework is pre-release alpha-1 with a zero-backwards-compat policy. A prior consumer-check found Inputs to read (on this PR branch
|
OpenHands Agent — CompletedModel: openrouter/minimax/minimax-m3 Run summary — openhands-run-27986503722-1SummaryPLAN-EVAL gate verdict for PR-B ( Verdict: Changes
Verification
Required fixes (the FAIL_PLAN remediation list)
Responses to review / issue commentsNo review-thread replies required; this is a planning-only PR comment. The verdict comment Remaining risks
Output mode
|
Planning only. Verdict artifact: plan-eval.md. T1 verified 0-consumer; T2 verified canonical exists; S3a (saga legacy) verified safe wholesale; S3b (workers schedule field) flagged unsound — defineScheduledTrigger is not a canonical replacement for defineJob().schedule(). Version policy: PASS (alpha-1 minor bump correct). No implementation. No deno.lock churn. Co-authored-by: openhands <openhands@all-hands.dev>
…hedule Ship T1 + T2 + S3a (saga) in PR-B; defer S3b (workers .schedule()) per PLAN-EVAL cycle 1 (workers cron has no canonical replacement — not a shim). Adds named S1 grep gate, deno doc --lint, jsr-audit surface note; corrects V8_HEAP_MB consumer (v8-profiles.ts fold into S1). Planning only.
|
@openhands-agent model=openrouter/minimax/minimax-m3 provider=openrouter output=pr-comment iterations=600 use harness — run PLAN-EVAL cycle 2 (separate-session plan gate) for the alpha-1 deprecation-shim removal run on PR #113 ( Planning-only PR. Do NOT implement, delete code, or change framework source. Verify the revised plan against the real surface and emit a verdict comment only. No What changed since cycle 1 (your
|
OpenHands Agent — CompletedModel: openrouter/minimax/minimax-m3 PLAN-EVAL — chore-alpha1-jsr-shim-removal (cycle 2)
TL;DRVerdict: Cycle-1 → cycle-2 diff (what changed)
Plan-Gate checklist results
Verification against the real surface (this branch, tip
|
Cycle 2 of 2 (final) for `chore-alpha1-jsr-shim-removal`. Verdict: PASS. Verified against tip `5d1bee91`: - S3b (workers-side slice) cleanly DEFERRED per option (b). Every workers-side surface (schedule field + scheduler port + builder method + scaffold + CLI flag + template + 4 docs/recipe/site references) intact and untouched by PR-B. - S3a (saga legacy) self-contained: no dep on deferred workers work; `saga-supervisor.ts:130` fold onto native default is correct. - V8_HEAP_MB fold verified: `v8-profiles.ts:12,46,73` is the only live consumer of any of the 8 cli aliases; other 7 re-grepped = 0-consumer. - Gate set verified sufficient for the (smaller) breaking removal: named S1 pre-delete grep gate + `deno doc --lint` per pkg + per-package test + `arch:check` + `publish:dry-run` + scaffold.runtime at IMPL. - Version policy + zero-cast re-confirmed. - Lock hygiene preserved — no `deno.lock` churn, no source edits. Next: implementation runs in separate session (WSL Codex). Order: S1 -> S2 -> S3a. Co-authored-by: openhands <openhands@all-hands.dev>
PLAN-EVAL cycle 2 verdict: PASS (final). Run: openhands-run-27988081250-1.
Fix research.md manifest naming bug (3 of 8 cli windows.ts aliases were listed by canonical suffix; real identifiers are WINDOWS_TARGET / WINDOWS_SERVICE_PREFIX / BUNDLE_EXTERNAL_PACKAGES) and record the final grep consumer proof: V8_HEAP_MB (v8-profiles.ts:12,46,73) is the only live alias consumer; the other 7 are 0-consumer. Append drift.md entry. Artifacts only; no source edits, no deno.lock churn. Lands on the PLAN-EVAL cycle-2 PASS tip. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018fq9V7ujx7e1rWXi57qkPG
|
[PHASE: IMPL] [SLICE: S1] [STATUS: LANDED] S1 Tier 1 pure aliases landed and pushed. Scope
Commit
Gate Evidence
Notes
|
PR-B S2 implementation — Tier 2 option fieldsCommit pushed: Scope:
Consumer proof:
Gates:
Hygiene:
|
PR-B S3a implementation — saga legacy subsystemCommit pushed: Scope:
Consumer proof:
Gates:
Hygiene:
Implementation is stopped here for IMPL-EVAL; no merge performed. |
PR-B implementation landed — 3 slices (T1 + T2 + S3a), pushed @
|
|
@openhands-agent model=openrouter/qwen/qwen3.7-max output=pr-comment use harness You are running IMPL-EVAL (final evaluator pass, separate session) on PR #113 — the alpha-1 breaking deprecation-shim removal. You are the certifying authority; the generator (WSL Codex) does NOT self-certify. Emit exactly one verdict: SKILLActivate and follow these repo skills before evaluating (read each SKILL.md):
Scope under evaluationBranch
Read order
Required verification
Report the raw exit code and summarize any failing suite/test names. Preserve lock hygiene: do NOT commit
Verdict rules
|
OpenHands Agent — CompletedModel: openrouter/qwen/qwen3.7-max IMPL-EVAL Summary — PR #113 (alpha-1 deprecation-shim removal)SummaryIndependent evaluator pass on PR #113 (branch Changes (verified in diff)
Validation (independent re-runs)
E2E Consumer/grep proofs: zero live consumers for every removed symbol across Test-removal scrutiny: Hygiene: 0 new Responses to review comments / issue commentsEvaluator verdict: All technical gates pass green. Two bounded violations recorded as arch-debt that do not block merge:
Merge recommendation: Land PR-B as-is. Resolve DEBT-1 at JSR-publish prep with single commit bumping Remaining risks
Run: https://github.com/rickylabs/netscript/actions/runs/27990255850 |
PR-B — alpha-1 deprecation-shim removal (BREAKING, zero-compat)
Removes the leftover
@deprecatedback-compat shims in the 6 JSR-umbrella packages. The frameworkis alpha-1 with a zero-backwards-compat policy, so these shims are removed rather than kept.
Consumer-check confirmed
mainalready carries every canonical API; this PR only deletes the shims.Status: PLANNING ONLY. This commit contains harness run artifacts. No source removal lands until
PLAN-EVAL returns PASS; implementation is done by WSL Codex in slices S1–S3.
Removal tiers (see
.llm/tmp/run/chore-alpha1-jsr-shim-removal/research.md)windows.tsconsts, dbbuildConnectionString,mssqlJsonExtension, telemetrycontext/job.ts.trustedConnection, freshserveStaticFiles/registerFsRoutes.schedule()+ plumbing, sagassaga-bus-legacyGates
scoped check/lint/fmt + per-package
deno task test+arch:check+publish:dry-run;e2e:cli run scaffold.runtime --cleanupat IMPL-EVAL.A separate PR-C sweeps the rest of the repo for project-wide legacy/deprecated code (alpha-1 zero-legacy).