chore(toolchain): align Aspire-core pins to 13.4.6 (CI + OpenHands + scaffold)#154
Merged
Conversation
…scaffold) Align Aspire-core CLI, SDK, and Aspire.Hosting integration pins to 13.4.6 across CI, OpenHands bootstrap toolchain, scaffold constants, generated config expectations, and docs examples. The OpenHands toolchain.env Aspire CLI pin was the stalest at 13.4.0; the remaining core pins were 13.4.4. Goal B is deferred with a debt entry because current Aspire 13.4 docs still state CommunityToolkit Deno and SQLite hosting APIs are not available for TypeScript AppHost in the required form. Validation: check and focused tests passed; final scaffold.runtime E2E attempted twice and failed at database.init due fixed-port bind on https://127.0.0.1:18891 after restoring Aspire 13.4.6.
Owner
Author
✅ scaffold.runtime e2e GREEN —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns Aspire-core pins to the current stable
13.4.6across CI, OpenHands bootstrap toolchain, scaffold constants, generatedaspire.config.jsonexpectations, and docs examples. Goal B is researched and deferred because the current Aspire 13.4 docs still say CommunityToolkit Deno/SQLite hosting APIs are not available for TypeScript AppHost in the required form.Scope
.llm/tmp/run/chore-align-aspire-13.4.6--impl/Slices
6804418f0bc452cbVersion Matrix
Before:
.github/toolchain.env: Aspire CLI13.4.0, Aspire SDK13.4.413.4.413.4.4Aspire.Hosting.PostgreSQL/MySql/SqlServer/Redis:13.4.4After:
.github/toolchain.env: Aspire CLI13.4.6, Aspire SDK13.4.613.4.613.4.6Aspire.Hosting.PostgreSQL/MySql/SqlServer/Redis:13.4.6CommunityToolkit pins remain on their separate line:
SCAFFOLD_VERSIONS.ASPIRE_HOSTING_DENO:13.4.0SCAFFOLD_VERSIONS.ASPIRE_HOSTING_SQLITE:13.4.0SCAFFOLD_COMMUNITY_TOOLKIT.VERSION: unchanged pending follow-upSweep Result
rtk grep '13\.4\.4': zero matches.rtk grep '13\.4\.0': two intentional matches, both CommunityToolkit Deno/SQLite constants inscaffold-versions.ts.Goal-B Verdict
Deferred.
aspire docs get deno-integrationsays TypeScript AppHost support forCommunityToolkit.Aspire.Hosting.Denois not yet available and it does not exposeaddDenoApp/addDenoTaskin the TypeScript SDK. SQLite docs likewise say SQLite hosting is C#-only for AppHost APIs and TypeScript should usebuilder.addConnectionString(...)with a parameter. A debt entry was added for a dedicated follow-up slice.Validation
deno run --allow-read --allow-run .llm/tools/run-deno-check.ts --root packages/cli --ext ts,tsx— pass, 524 files selected, 0 diagnostics.deno lint --no-config packages/cli/src/kernel/constants/scaffold/scaffold-versions.ts packages/cli/src/kernel/constants/scaffold/scaffold-aspire.ts packages/cli/src/kernel/templates/aspire/generate-aspire-config_test.ts— pass, checked 3 touched CLI TS files.deno test --allow-all packages/cli/src/kernel/templates/aspire/generate-aspire-config_test.ts packages/cli/src/kernel/constants/version-drift_test.ts— pass, 2 tests / 2 steps.deno task check:scaffold-versions— pass, 10 scaffold pins stable.deno task e2e:cli run scaffold.runtime --cleanup --format pretty— failed twice in native WSL worktree atdatabase.init, raw exit code 1, countspassed=10 failed=1. Both failures were Aspire fixed-port bind failures onhttps://127.0.0.1:18891; cleanup ran,aspire psreturned[], and Linuxssshowed no WSL listener after cleanup. The generated E2E project did restore Aspire SDK/package13.4.6before the bind failure.Drift / Debt
.llm/harness/debt/arch-debt.mdentry.worklog.mdanddrift.md.