fix(cli): scaffold emits aspire start not aspire run (alpha.11 Slice G)#161
Merged
Conversation
Owner
Author
Slice G — scaffold emits
|
| File | Change |
|---|---|
init-orchestrator.ts |
next-step aspire run → aspire start (TS AppHost) |
generate-readme.ts |
4 sites: start cmd, tree comment, command table, provision prose (legacy C# keeps dotnet run) |
main.ts.template |
startup-banner comment |
generate-aspire-config.ts |
doc comment |
embedded.generated.ts |
regenerated from the template (not hand-edited) |
orchestrate-init_test.ts / generators_test.ts |
expectations flipped + 3 new negative assertions (!md.includes('aspire run')) |
Verification
- Targeted tests:
18 passed / 0 failed(generators + orchestrate-init). - CI on this PR:
check-test✅,quality✅,scaffold-static✅,scaffold-runtime (aspire + docker + postgres)✅,deps-report✅. - Residual
aspire runinpackages/cli/src: 3 — all are the new negative test assertions (intentional; they assert the string is absent from generated READMEs).
Legacy C# AppHost path intentionally retains dotnet run. Zero logic changes — string/template + test deltas only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the alpha.11 fix-train gap where scaffolded project output still instructed users to run the invalid
aspire runcommand even though the TypeScript AppHost template already points ataspire start. Refs #141 #153.Scope
fix/scaffold-aspire-start-alpha11-gChanges
aspire runtoaspire start.aspire start # start TypeScript AppHost.packages/cli/src/kernel/assets/embedded.generated.tsviadeno task gen:assets-barrel.aspire startand rejectsaspire run; legacy C# AppHost remainsdotnet run.Validation
deno run --allow-read --allow-run .llm/tools/run-deno-check.ts --root packages/cli --ext ts,tsx— PASS, 527 files selected, 5 batches, 0 failed batches.deno test --allow-all packages/cli/src/kernel/templates/workspace/generators_test.ts packages/cli/src/kernel/application/scaffold/orchestrate-init_test.ts— PASS, 18 passed / 0 failed.rg -n "aspire run" packages/cli/src --glob '!**/*_test.ts' --glob '!**/*.test.ts'— PASS, no scaffold source/template occurrences.git diff --check— PASS.deno lint --no-config <touched .ts files>— PASS, 6 files checked.deno fmt --check --no-config --single-quote --line-width 100 --indent-width 2 packages/cli/src/kernel/templates/workspace/generate-readme.ts— PASS.Requested wrappers with the exact root commands were also run:
deno run --allow-read --allow-run .llm/tools/run-deno-lint.ts --root packages/cli --ext ts,tsx— exit 1 with JSON summary showing 527 files selected and 0 findings. Rawdeno lint packages/cli/...reportsNo target files foundbecause rootdeno.jsonexplicitly excludespackages/cli/underlint.exclude.deno run --allow-read --allow-run .llm/tools/run-deno-fmt.ts --root packages/cli --ext ts,tsx— exit 1 with JSON summary showing 527 files selected, 0 findings, and failed batches. Rawdeno fmt --check packages/cli/...reportsNo target files foundbecause rootdeno.jsonexplicitly excludespackages/cli/underfmt.exclude.Harness
9b82271eDrift / Debt
packages/clibecause the root Deno config excludes that package from lint/fmt target discovery.