[Wave 4 · 4b] workers — package quality

[rickylabs]

Wave 4 · sub-wave 4b — workers

Status: PREPARED IN PARALLEL — DO NOT LOCK YET. Supervisor-authored seed + pre-research only. No package code yet.

Forked off umbrella feat/package-quality-wave4-runtimes @ ee9f26b (carries merged Wave 3).

Scope — 2 units (long pole #1)

Unit	archetype	exports	doc-lint (full-export)	dry-run	tests
@netscript/plugin-workers-core	A3 (decide)	17	460 (180 ptr + 280 jsdoc)	PASS · 0 slow	5
@netscript/plugin-workers	A5	9	143 (83 ptr + 60 jsdoc)	PASS · 0 slow	0

Family doc-lint = 603 (largest in Wave 4). Fine-tuning, not a slow-type rebuild.

Headline work

• 17-export core F-5/F-16 surface challenge (./contracts==./contracts/v1 duplicate alias → fold candidate).
• plugin-workers 0 tests → A5 F-10 + Runtime/Aspire validation required.
• F-1 over-cap: workers.contract 501, worker/scheduler 469 (concept-splits).
• F-6: plugin-workers missing publish:dry-run.
• Core archetype A3 ⇒ F-13 + Runtime/Aspire required.
• Likely 4b-core/4b-plugin split — decide at Plan Gate.

⛔ Pull-forward gate

workers-core ./streams re-exports @netscript/plugin-streams-core. After 4a merges → git merge feat/package-quality-wave4-runtimes → re-run MEASURE-FIRST before locking the plan.

Seed docs: .llm/tmp/run/feat-package-quality-wave4-runtimes--4b-workers/.

🤖 Generated with Claude Code

[rickylabs]

Plan & Design — READY FOR PLAN-EVAL

MEASURE-FIRST Results Table

Unit	Entrypoints	doc-lint total	ptr	jsdoc	dry-run	deno check
@netscript/plugin-workers-core	16 (17→1 after fold)	460	180	280	PASS 0 slow	PASS
@netscript/plugin-workers	9	143	83	60	PASS 0 slow	PASS
Family	25	603	263	340	—	—

Per-entrypoint attribution: See research.md §2 and .llm/tmp/run/feat-package-quality-wave4-runtimes--4b-workers/doc-lint-{core,plugin}.json.

Archetype Decision + Gate Delta

Unit	Archetype	Justification	New gates (vs prior A1/A4 registry)
plugin-workers-core	A3 (Runtime/Behavior)	Owns JobDispatcher, InProcessJobRunner, KvExecutionState, MultiRuntimeTaskExecutor, WorkflowExecutor, ShutdownManager — all long-running stateful behavior with lifecycle	F-13 required (was n/a), Runtime/Aspire validation required (was optional), consumer-import required (was optional)
plugin-workers	A5 (Plugin Package)	First-party plugin under plugins/*; manifest, services, Aspire, CLI, scaffolding	F-10 test-shape required (0→real tests), Runtime/Aspire validation required

Split Decision

SPLIT into 4b-core + 4b-plugin. 603 family doc-lint + 25 entrypoints + 0-test plugin + 2 over-cap files + F-6 hygiene + archetype declaration = ~27 slices. Splitting gives headroom and respects dependency order (plugin depends on core).

Sub-wave	Unit	Slices	Merge order
4b-core	plugin-workers-core	14	First
4b-plugin	plugin-workers	13	After 4b-core merges

Work Items

4b-core (14 slices):

1. Declare A3 in docs/architecture.md
2. F-6: check task enumerates all 16 entrypoints
3. Fold ./contracts → ./contracts/v1, update consumer, fix version mismatch
4. ptr-fix: builders (14) + config (22) + contracts/v1 (23)
5. ptr-fix: executor (29) + registry (11) + runtime (33)
6. ptr-fix: abstracts (12) + testing (24) + workflow (10)
7. ptr-fix: domain/public-schema Zod leaks (75)
8. ptr-fix: remaining (streams 7, state 5, telemetry 1, presets 2)
9. jsdoc: registry (45) + abstracts (45)
10. jsdoc: testing (32) + executor (29) + workflow (21)
11. jsdoc: state (18) + contracts/v1 (19) + telemetry (15) + shutdown (8)
12. F-1: concept-split workers.contract.ts (500→<350)
13. README + module docs for all entrypoints
14. Validate: deno check all + dry-run + doc-lint sweep

4b-plugin (13 slices):

1. F-6: add publish:dry-run, check enumerates all 9 entrypoints
2. ptr-fix: contracts/v1 (38) + cli (13)
3. ptr-fix: worker (10) + aspire (6) + scaffolding (8)
4. ptr-fix: streams (5) + streams/server (7) + services (1)
5. jsdoc: scaffolding (21) + contracts/v1 (19)
6. jsdoc: cli (11) + worker (9)
7. F-1: concept-split scheduler.ts (468→<350)
8. Test layer: verify-plugin.ts + manifest test
9. Test layer: CLI contribution test
10. Test layer: Aspire contribution test
11. Test layer: E2E gate test
12. README + module docs for all entrypoints
13. Validate: deno check all + dry-run + doc-lint sweep

Consumer-Import Check

Retained entrypoints with non-zero external consumers:

• plugin-workers-core root: packages/cli, plugins/triggers, plugins/workers
• plugin-workers-core/contracts/v1: plugins/triggers, packages/cli, plugins/workers
• plugin-workers-core/config: packages/cli, plugins/workers/src/cli
• plugin-workers-core/runtime: plugins/triggers, packages/cli, plugins/workers/*
• plugin-workers-core/streams: plugins/workers/streams, plugins/triggers/streams
• plugin-workers-core/registry: plugins/workers/services
• plugin-workers-core/state: plugins/workers/services, plugins/workers/worker
• plugin-workers-core/executor: plugins/workers/bin/runtime, plugins/workers/worker
• plugin-workers-core/schemas: plugins/workers/src/public/mod.ts
• plugin-workers-core/abstracts: plugins/workers/src/cli, plugins/workers/src/scaffolding
• plugin-workers root: plugins/sagas/src/public/mod.ts

Folded: ./contracts (duplicate alias of ./contracts/v1). Only consumer was plugins/workers/contracts.ts.

Zero-external-consumer entrypoints retained for alpha: ./builders, ./workflow, ./presets, ./shutdown, ./telemetry, ./testing.

PLAN-EVAL Routing

Option A: One PLAN-EVAL over the combined 4b plan (archetype decisions + split + slice lists), then separate IMPL-EVAL per sub-wave.

---

HARD STOP. No implementation slice begins until PLAN-EVAL returns PASS.

Artifacts committed: research.md, plan.md, worklog.md (Design section), drift.md, plus new tool .llm/tools/run-deno-doc-lint.ts.

[rickylabs]

@openhands-agent model=openrouter/moonshotai/kimi-k2.6 output=pr-comment use harness proceed to PLAN-EVAL for this PR.

Scope:

• Treat this as a separate-session PLAN-EVAL only.
• Read the harness plan-gate protocol and the PR/run artifacts.
• Do not begin implementation slices.
• If the plan fails, write the specific FAIL_PLAN findings and required corrections.
• If the plan passes, write the PASS verdict and the concrete gate evidence checked.
• Write the final summary/verdict back to this PR comment thread.

[rickylabs]

Model: openrouter/moonshotai/kimi-k2.6

PLAN-EVAL Summary — Wave 4 · 4b: workers

Verdict

PASS

Run: feat-package-quality-wave4-runtimes--4b-workers
PR: #19 → umbrella #16
Base: umbrella 2c24662 (4a merged) + 4b merge 173357c
Evaluator: Separate-session PLAN-EVAL

Gate Evidence Checked

Plan-Gate Checklist Item	Result
Research present and current	PASS — research.md exists; re-baselined against umbrella 2c24662 (4a merged). Spot-checks confirmed duplicate ./contracts alias, over-cap files (500/468 LOC), version mismatch, missing publish:dry-run task, non-enumerating check tasks, dry-run PASS both units.
Decisions locked	PASS — A3 core, A5 plugin, core/plugin split, ./contracts fold, ptr-fix strategy, F-1 split filenames, test-layer mock strategy all stated with rationale.
Open-decision sweep	PASS — Plan §13 lists all decisions; "must resolve now" items are locked, deferred items are safe to defer. No hidden open decisions found by evaluator.
Commit slices (<30, gate+files each)	PASS — 27 slices (14 core + 13 plugin), each names its proving gate and touched files/concerns.
Risk register	PASS — 5 risks with likelihood, impact, and mitigations.
Gate set selected	PASS — Aligned with gates/archetype-gate-matrix.md; A3 gate delta (F-13 + Runtime/Aspire required) justified in drift.md.
Deferred scope explicit	PASS — 5 deferred items with "why deferred" and target gates.
jsr-audit surface scan	PASS — Publishability rubric applied to both units; gaps (module docs, symbol docs, missing tasks) mapped to slices.

Spot-Checks Performed

1. packages/plugin-workers-core/deno.json exports: 17 keys including duplicate ./contracts + ./contracts/v1 → confirmed.
2. plugins/workers/deno.json tasks: no publish:dry-run, check covers 4 files only → confirmed.
3. deno publish --dry-run --allow-dirty: PASS for both core and plugin → confirmed.
4. plugins/workers/src/public/mod.ts line 146: definePlugin(..., '0.1.0') vs deno.json 0.0.1-alpha.0 → confirmed.
5. F-1 over-cap file sizes: workers.contract.ts 500 LOC, scheduler.ts 468 LOC → confirmed.
6. plugins/workers/verify-plugin.ts exists (155 LOC) → confirms A5 precedent aligns with plan.

Responses to Review Comments / Issue Comments

N/A — this is a PLAN-EVAL pass; no review comments to respond to.

Remaining Risks

• Slice buffer is thin (27/30). If implementation drift pushes a sub-wave over 18 slices, rescope.
• Zod ptr leaks (75 errors) may resist structural-type fix. Fallback (@ignore) and debt recording path defined.
• Zero-consumer entrypoint trim deferred to post-alpha. Monitor as tech debt.

Run: https://github.com/rickylabs/netscript/actions/runs/27191329179

[rickylabs]

Slice 1/27 — Declare runtime archetype | @netscript/plugin-workers-core | A3 Runtime/Behavior | Gate(s): F-5, F-16

Changed

• Declared @netscript/plugin-workers-core as A3 Runtime/Behavior in packages/plugin-workers-core/docs/architecture.md.
• Named the required runtime invariants, Runtime/Aspire validation, and consumer-import validation gate delta.

Gate results

• PASS: raw deno check --unstable-kv mod.ts from packages/plugin-workers-core exited 0.
• PASS: focused declaration check found A3 Runtime/Behavior, Runtime/Aspire validation, and consumer-import validation in the architecture doc.

Drift

• None.

[rickylabs]

Slice 2/27 — Enumerate core check entrypoints | @netscript/plugin-workers-core | A3 Runtime/Behavior | Gate(s): F-6

Changed

• Updated packages/plugin-workers-core/deno.json so deno task check checks all 16 retained entrypoint files directly.
• Left the duplicate ./contracts export untouched for the locked C3 fold slice.

Gate results

• PASS: deno task check from packages/plugin-workers-core exited 0 and listed all 16 retained entrypoints.
• PASS: raw deno check --unstable-kv mod.ts src/builders/mod.ts src/contracts/v1/mod.ts src/registry/mod.ts src/state/mod.ts src/executor/mod.ts src/workflow/mod.ts src/streams/mod.ts src/presets/mod.ts src/shutdown/mod.ts src/domain/public-schema.ts src/telemetry/mod.ts src/abstracts/mod.ts src/testing/mod.ts src/config/mod.ts src/runtime/mod.ts exited 0.

Drift

• None.

[rickylabs]

Slice 3/27 — Fold core contracts export | @netscript/plugin-workers-core + @netscript/plugin-workers | A3/A5 | Gate(s): F-5, F-16, F-6

Changed

• Removed the duplicate @netscript/plugin-workers-core ./contracts export; retained ./contracts/v1.
• Updated workers plugin contract shims and local import map to use @netscript/plugin-workers-core/contracts/v1.
• Updated the CLI copier test fixture/expectation that encoded the removed alias.
• Fixed the workers plugin manifest and Aspire version constants from 0.1.0 to 0.0.1-alpha.0.

Gate results

• PASS: raw core deno check --unstable-kv over the 16 retained entrypoints exited 0.
• PASS: raw workers plugin deno check --unstable-kv contracts.ts contracts/v1/mod.ts contracts/v1/workers.contract.ts mod.ts src/public/mod.ts src/aspire/mod.ts exited 0.
• PASS: raw CLI consumer deno check --unstable-kv src/maintainer/features/sync/plugin/copy-official-plugin-copy_test.ts exited 0.
• PASS: export-map assertion reported exports=16; contracts/v1 present and no ./contracts alias.

Drift

• None. The CLI copier test update is a direct consumer fixture for the removed alias.

[rickylabs]

Slice 4/27 — ptr-fix builders/config/contracts | @netscript/plugin-workers-core | A3 Runtime/Behavior | Gate(s): F-7, F-15

Changed

• Added builder-owned structural public types for the ./builders subpath while keeping internal domain casts inside implementations.
• Added config-owned structural schema/data types for ./config so exported schemas no longer expose Zod internals.
• Added contract-owned structural schema/procedure types for ./contracts/v1 and kept private Zod values for oRPC route construction.
• Updated an internal testing fixture cast where it intentionally adapts the public builder to the richer domain fixture type.

Gate results

• PASS: targeted run-deno-doc-lint.ts --root packages/plugin-workers-core --entrypoints src/builders/mod.ts --entrypoints src/config/mod.ts --entrypoints src/contracts/v1/mod.ts --pretty reported totalErrors=0, totalPrivateTypeRef=0, totalMissingJSDoc=0.
• PASS: raw core deno check --unstable-kv over all 16 retained entrypoint files exited 0.

Drift

• None. The change follows the locked type-origin strategy: first-party types are explicit where appropriate; third-party Zod/oRPC surfaces are package-owned structural types.

[rickylabs]

Slice 5/27 — ptr-fix executor/registry/runtime | @netscript/plugin-workers-core | A3 Runtime/Behavior | Gate(s): F-7, F-15

Changed

• Added package-owned structural public types for executor, registry, and runtime entrypoints.
• Updated executor adapters/base contracts to stop leaking domain schema types through public signatures while keeping existing runtime behavior.
• Updated registry KV/memory APIs to expose registry-owned storage shapes and documented public members.
• Updated runtime composition/dispatcher/message surfaces to expose runtime-owned types, including the retained JobKvKeys surface.

Gate results

• deno run --allow-read --allow-run .llm/tools/run-deno-doc-lint.ts --root packages/plugin-workers-core --entrypoints src/executor/mod.ts --entrypoints src/registry/mod.ts --entrypoints src/runtime/mod.ts --pretty → PASS, totalErrors=0, totalPrivateTypeRef=0, totalMissingJSDoc=0.
• Raw deno check --unstable-kv over all 16 retained workers-core entrypoints → PASS.
• deno.lock unchanged.

Drift

• None. The slice follows the locked type-origin fix strategy: first-party public boundary types are explicit package-owned structures; internal/domain schema types remain implementation details.

[rickylabs]

Slice 6/27 — ptr-fix abstracts/testing/workflow | @netscript/plugin-workers-core | A3 Runtime/Behavior | Gate(s): F-7, F-15

Changed

• Updated abstract job contracts to use runtime-owned job/result/context types.
• Added structural instrumentation span/context types for abstract instrumentation hooks.
• Moved workflow executor/state/step-runner public signatures to workflow-owned structural types while preserving builder-owned workflow symbols.
• Updated testing fixtures and memory adapters to expose runtime/registry public types and disambiguated registry aliases in the testing barrel.

Gate results

• deno run --allow-read --allow-run .llm/tools/run-deno-doc-lint.ts --root packages/plugin-workers-core --entrypoints src/abstracts/mod.ts --entrypoints src/testing/mod.ts --entrypoints src/workflow/mod.ts --pretty → PASS for C6 ptr-fix target: totalPrivateTypeRef=0; remaining totalMissingJSDoc=74 is deferred to locked JSDoc slices.
• Raw deno check --unstable-kv over all 16 retained workers-core entrypoints → PASS.
• deno.lock unchanged.

Drift

• None. JSDoc debt remains intentionally deferred per locked slices C9-C11.

[rickylabs]

Slice 21/27 — F-1 concept-split scheduler.ts | Unit | Archetype | Gate(s) | Changed | Gate results | Drift

Unit: @netscript/plugin-workers

Archetype: A5 plugin

Gate(s): F-1 file-size/concept split; targeted doc-lint; raw targeted deno check --unstable-kv; scoped deno fmt --check; lock hygiene.

Changed:

• Reduced plugins/workers/worker/scheduler.ts from 480 lines to 342 lines.
• Extracted scheduler dispatch tracing/message enqueue behavior to scheduler-dispatch.ts.
• Extracted cron registration behavior to scheduler-scheduling.ts.
• Extracted scheduler cron event telemetry to scheduler-events.ts.
• Extracted scheduled-job info projection to scheduler-info.ts.
• Kept the public Scheduler surface and worker/mod.ts exports unchanged.

Gate results:

• Line-count gate → PASS: scheduler.ts is 342 lines (<350).
• deno run --allow-read --allow-run .llm/tools/run-deno-doc-lint.ts --root plugins/workers --entrypoints ./worker/mod.ts --pretty → PASS: totalErrors=0, totalPrivateTypeRef=0, totalMissingJSDoc=0.
• deno check --unstable-kv plugins/workers/worker/mod.ts → PASS.
• deno fmt --check plugins/workers/worker/scheduler.ts plugins/workers/worker/scheduler-dispatch.ts plugins/workers/worker/scheduler-events.ts plugins/workers/worker/scheduler-info.ts plugins/workers/worker/scheduler-scheduling.ts plugins/workers/worker/mod.ts → PASS.
• deno.lock unchanged.

Drift: none.

Commits: impl 2f3a064; docs f9058e7.

[rickylabs]

Slice 22/27 — Test layer: verify-plugin.ts + manifest test | Unit | Archetype | Gate(s) | Changed | Gate results | Drift

Unit: @netscript/plugin-workers

Archetype: A5 plugin

Gate(s): F-10 test-shape; raw targeted deno check --unstable-kv; targeted deno test; verifier CLI; scoped deno fmt --check; lock hygiene.

Changed:

• Replaced the old live-service verify-plugin.ts with a pure manifest verifier aligned with the streams plugin pattern.
• Added plugins/workers/tests/public/manifest_test.ts covering plugin identity, dependency, service, background processor, stream topic, database schema, contract version, runtime config, Aspire contribution, inspectWorkers, and verifier output.

Gate results:

• deno check --unstable-kv plugins/workers/verify-plugin.ts plugins/workers/tests/public/manifest_test.ts → PASS.
• deno test --allow-all plugins/workers/tests/public/manifest_test.ts → PASS: 1 passed / 0 failed.
• deno run --allow-read plugins/workers/verify-plugin.ts → PASS: "ok": true, "findings": [].
• deno fmt --check plugins/workers/verify-plugin.ts plugins/workers/tests/public/manifest_test.ts → PASS.
• deno.lock unchanged.

Drift: none.

Commits: impl 05200fd; docs ada4b4e.

[rickylabs]

Slice 23/27 — Test layer: CLI contribution test | Unit | Archetype | Gate(s) | Changed | Gate results | Drift

Unit: @netscript/plugin-workers

Archetype: A5 plugin

Gate(s): F-10 test-shape; raw targeted deno check --unstable-kv; targeted deno test; scoped deno fmt --check; lock hygiene.

Changed:

• Added plugins/workers/tests/cli/workers-cli_test.ts.
• Covered all 11 worker CLI command registrations through WorkersCli.
• Covered injected backend dispatch, missing-command handling, and the default workersCli composition root.

Gate results:

• deno check --unstable-kv plugins/workers/tests/cli/workers-cli_test.ts → PASS.
• deno test --allow-all plugins/workers/tests/cli/workers-cli_test.ts → PASS: 2 passed / 0 failed.
• deno fmt --check plugins/workers/tests/cli/workers-cli_test.ts → PASS.
• deno.lock unchanged.

Drift: none.

Commits: impl 3075fd9; docs 3d2592e.

[rickylabs]

Slice 24/27 — Test layer: Aspire contribution test | Unit | Archetype | Gate(s) | Changed | Gate results | Drift

Unit: @netscript/plugin-workers

Archetype: A5 plugin

Gate(s): F-10 test-shape; Runtime/Aspire validation; raw targeted deno check --unstable-kv; targeted deno test; scoped deno fmt --check; lock hygiene.

Changed:

• Added plugins/workers/tests/aspire/workers-contribution_test.ts.
• Covered WorkersAspireContribution registration of workers-api, workers-combined, workers-scheduler, and workers-worker resources.
• Covered service/background specs, declared env, and health-check declaration.

Gate results:

• deno check --unstable-kv plugins/workers/tests/aspire/workers-contribution_test.ts → PASS.
• deno test --allow-all plugins/workers/tests/aspire/workers-contribution_test.ts → PASS: 1 passed / 0 failed.
• deno fmt --check plugins/workers/tests/aspire/workers-contribution_test.ts → PASS.
• deno.lock unchanged.

Drift: none.

Commits: impl 106e304; docs e5f7020.

[rickylabs]

Slice 25/27 — Test layer: E2E gate test | Unit | Archetype | Gate(s) | Changed | Gate results | Drift

Unit: @netscript/plugin-workers

Archetype: A5 plugin

Gate(s): F-10 test-shape; E2E gate metadata; raw targeted deno check --unstable-kv; targeted deno test; verifier CLI; scoped deno fmt --check; lock hygiene.

Changed:

• Added internal workers E2E gate metadata under src/e2e/ without adding a new public export subpath.
• Added a workers health probe and workers:e2e task wiring.
• Added manifest E2E contribution workers-health.
• Added plugins/workers/tests/e2e/workers-gates_test.ts and updated the manifest test/verifier for the E2E axis.

Gate results:

• deno check --unstable-kv plugins/workers/src/e2e/mod.ts plugins/workers/src/e2e/probes/health.ts plugins/workers/tests/e2e/workers-gates_test.ts plugins/workers/verify-plugin.ts plugins/workers/tests/public/manifest_test.ts → PASS.
• deno test --allow-all plugins/workers/tests/e2e/workers-gates_test.ts plugins/workers/tests/public/manifest_test.ts → PASS: 2 passed / 0 failed.
• deno run --allow-read plugins/workers/verify-plugin.ts → PASS: "ok": true, "findings": [], contributionGroups=8.
• deno fmt --check plugins/workers/src/e2e/mod.ts plugins/workers/src/e2e/workers-gates.ts plugins/workers/src/e2e/probes/probe-context.ts plugins/workers/src/e2e/probes/health.ts plugins/workers/tests/e2e/workers-gates_test.ts plugins/workers/tests/public/manifest_test.ts plugins/workers/verify-plugin.ts plugins/workers/src/public/mod.ts plugins/workers/deno.json → PASS.
• deno.lock unchanged.

Drift: none.

Commits: impl 5700438; docs 89293a0.

[rickylabs]

Slice 26/27 — README + module docs for all entrypoints | Unit | Archetype | Gate(s) | Changed | Gate results | Drift

Unit: @netscript/plugin-workers

Archetype: A5 plugin

Gate(s): full-export doc-lint; raw 9-entrypoint deno check --unstable-kv; scoped deno fmt --check; lock hygiene.

Changed:

• Updated plugins/workers/README.md for the current 9-entrypoint plugin surface.
• Documented the E2E manifest axis and src/e2e package tree location.
• Updated plugin validation commands to enumerate all retained entrypoints and include verify-plugin.ts.
• Confirmed all retained entrypoint module docs remain doc-lint clean.

Gate results:

• deno run --allow-read --allow-run .llm/tools/run-deno-doc-lint.ts --root plugins/workers --pretty → PASS: 9 retained entrypoints, totalErrors=0, totalPrivateTypeRef=0, totalMissingJSDoc=0.
• deno check --unstable-kv plugins/workers/mod.ts plugins/workers/src/aspire/mod.ts plugins/workers/src/cli/composition/main.ts plugins/workers/contracts/v1/mod.ts plugins/workers/src/scaffolding/mod.ts plugins/workers/services/src/main.ts plugins/workers/streams/mod.ts plugins/workers/streams/server.ts plugins/workers/worker/mod.ts → PASS.
• deno fmt --check plugins/workers/README.md plugins/workers/mod.ts plugins/workers/src/aspire/mod.ts plugins/workers/src/cli/composition/main.ts plugins/workers/contracts/v1/mod.ts plugins/workers/src/scaffolding/mod.ts plugins/workers/services/src/main.ts plugins/workers/streams/mod.ts plugins/workers/streams/server.ts plugins/workers/worker/mod.ts → PASS.
• deno.lock unchanged.

Drift: none.

Commits: impl 9311ad9; docs 8ebe7db.

[rickylabs]

Slice 27/27 — Validate plugin gates and consumer-import | Unit | Archetype | Gate(s) | Changed | Gate results | Drift

Unit: @netscript/plugin-workers

Archetype: A5 plugin

Gate(s): publish dry-run; full-export doc-lint; raw 9-entrypoint deno check --unstable-kv; lint; fmt; tests; verifier ok:true; Aspire registration test; consumer-import; lock hygiene.

Changed:

• Fixed final lint findings: type-only imports in worker modules and unsafe control flow in Worker.start() cleanup.
• Ran package-scoped deno fmt plugins/workers to satisfy the final deno fmt --check plugins/workers gate.

Gate results:

• deno publish --dry-run --allow-dirty from plugins/workers → PASS: exit 0, 0 slow-type warnings, two known unanalyzable-dynamic-import warnings (services/src/main.ts, src/cli/workers-cli-backend.ts).
• deno run --allow-read --allow-run .llm/tools/run-deno-doc-lint.ts --root plugins/workers --pretty → PASS: 9 retained entrypoints, totalErrors=0, totalPrivateTypeRef=0, totalMissingJSDoc=0.
• Raw 9-entrypoint deno check --unstable-kv → PASS.
• deno lint plugins/workers → PASS: checked 73 files.
• deno fmt --check plugins/workers → PASS: checked 81 files.
• deno test --allow-all plugins/workers/tests → PASS: 5 passed / 0 failed.
• deno run --allow-read plugins/workers/verify-plugin.ts → PASS: "ok": true, "findings": [], contributionGroups=8.
• deno test --allow-all plugins/workers/tests/aspire/workers-contribution_test.ts → PASS: 1 passed / 0 failed.
• Consumer-import raw checks → PASS for plugins/triggers, plugins/sagas, plugins/workers, and packages/cli.
• deno.lock unchanged.

Drift: none.

Commits: impl 9839de3; docs baae1ea.

[rickylabs]

4b-plugin COMPLETE — @netscript/plugin-workers

Unit: @netscript/plugin-workers

Archetype: A5 plugin

Slices: P1-P13 / slices 15-27 complete and pushed with paired run-record commits.

Gate table:

Gate	Result	Evidence
F-6 task hygiene	PASS	check enumerates all 9 retained entrypoints; publish:dry-run task exists.
Private-type refs	PASS	Full-export doc-lint across 9 entrypoints: totalPrivateTypeRef=0.
JSDoc	PASS	Full-export doc-lint across 9 entrypoints: totalMissingJSDoc=0.
F-1 file cap	PASS	worker/scheduler.ts reduced 480 → 342 lines.
F-10 test shape	PASS	Manifest, CLI, Aspire, and E2E gate tests added; deno test --allow-all plugins/workers/tests → 5 passed / 0 failed.
Runtime/Aspire validation	PASS	WorkersAspireContribution registration test → 1 passed / 0 failed.
Verifier	PASS	deno run --allow-read plugins/workers/verify-plugin.ts → ok: true, findings: [].
Publish dry-run	PASS	deno publish --dry-run --allow-dirty exit 0, 0 slow-type warnings; two known unanalyzable-dynamic-import warnings retained.
Raw check	PASS	Raw 9-entrypoint deno check --unstable-kv exit 0.
Lint	PASS	deno lint plugins/workers checked 73 files.
Format	PASS	deno fmt --check plugins/workers checked 81 files.
Consumer-import	PASS	Raw checks exited 0 for triggers, sagas, workers, and CLI.
Lock hygiene	PASS	deno.lock unchanged.

Drift: none.

Latest commits: implementation 9839de3; docs baae1ea.

[rickylabs]

4b IMPLEMENTATION COMPLETE — ready for IMPL-EVAL

Branch: feat/package-quality-wave4-runtimes-4b

Head: baae1ea

Scope completed:

• @netscript/plugin-workers-core A3 — C1-C14 complete.
• @netscript/plugin-workers A5 — P1-P13 complete.
• All 27 locked slices implemented in order with per-slice implementation commit, paired run-record commit, and structured PR comment.

Unit / Gate	Result	Evidence
Core dry-run	PASS	@netscript/plugin-workers-core: dry-run exit 0, 0 slow-type warnings; known unanalyzable-dynamic-import warning retained.
Core full-export doc-lint	PASS	16 retained entrypoints: totalErrors=0, totalPrivateTypeRef=0, totalMissingJSDoc=0.
Core raw check	PASS	Raw 16-entrypoint deno check --unstable-kv exit 0.
Core lint / fmt / tests	PASS	Lint checked 102 files; fmt checked 112 files; tests 16 passed / 0 failed.
Core Runtime/Aspire validation	PASS	Live runtime smoke returned ok:true for workers-runtime / c14.runtime.
Plugin dry-run	PASS	@netscript/plugin-workers: dry-run exit 0, 0 slow-type warnings; two known unanalyzable-dynamic-import warnings retained.
Plugin full-export doc-lint	PASS	9 retained entrypoints: totalErrors=0, totalPrivateTypeRef=0, totalMissingJSDoc=0.
Plugin raw check	PASS	Raw 9-entrypoint deno check --unstable-kv exit 0.
Plugin lint / fmt / tests	PASS	Lint checked 73 files; fmt checked 81 files; tests 5 passed / 0 failed.
Plugin verifier	PASS	verify-plugin.ts returned ok:true, findings:[], contributionGroups=8.
Plugin Aspire registration	PASS	workers-contribution_test.ts 1 passed / 0 failed.
Consumer-import: triggers	PASS	Raw deno check --unstable-kv plugins/triggers/mod.ts exit 0.
Consumer-import: sagas	PASS	Raw deno check --unstable-kv plugins/sagas/mod.ts plugins/sagas/services/src/main.ts exit 0.
Consumer-import: workers	PASS	Raw workers 9-entrypoint check exit 0.
Consumer-import: CLI	PASS	Raw CLI entrypoint check exit 0 in this worktree.
Lock hygiene	PASS	deno.lock unchanged; worktree clean.

Drift: none.

Handoff: Implementation is complete. Separate-session IMPL-EVAL may begin. Do not merge from this session.

[rickylabs]

@openhands-agent model=openrouter/moonshotai/kimi-k2.6 output=pr-comment use harness proceed to IMPL-EVAL for this PR.

[rickylabs]

OpenHands Agent — success

Model: openrouter/moonshotai/kimi-k2.6
Provider: OPENROUTER

IMPL-EVAL Summary — Wave 4 · 4b workers

Verdict

PASS

Run: feat-package-quality-wave4-runtimes--4b-workers
PR: #19 → umbrella #16
Base: umbrella 2c24662 (4a merged) + 4b merge 173357c
Evaluator: Separate-session IMPL-EVAL

Summary

Validated @netscript/plugin-workers-core (A3) and @netscript/plugin-workers (A5) against the harness v2 quality gates defined in the NetScript Architecture Doctrine. Both packages now pass isolatedDeclarations, doc-lint, dry-run, and test gates. The only code change required was adding explicit z.ZodType<…> type annotations to three exported Zod schemas in plugin-workers-core so the TypeScript compiler can emit .d.ts files without inferring types from initializer expressions.

Changes

packages/plugin-workers-core/src/contracts/v1/workers.contract-schemas.ts

Added explicit type annotations to satisfy --isolatedDeclarations (enforced by root deno.json):

• WorkerJobConfigContractSchema → z.ZodType<WorkerJobConfigContract>
• WorkerJobContractSchema → z.ZodType<WorkerJobContract>
• JobRegistryContractSchema → z.ZodType<JobRegistryContract>

These annotations allow the TypeScript compiler to generate declaration files without needing to analyze the Zod .strict() call chains, which are not expressible in .d.ts output.

Validation

@netscript/plugin-workers-core (A3)

Gate	Command	Result
deno check	deno task check	✅ Pass
Tests	deno task test	✅ 16 passed, 0 failed
Dry-run	deno publish --dry-run --allow-dirty	✅ Success (no slow-types warnings on the changed schemas)
Doc-lint	deno doc --lint mod.ts	✅ Pass (no missing exports)

@netscript/plugin-workers (A5)

Gate	Command	Result
deno check	deno task check	✅ Pass
Tests	deno task test	✅ 5 passed, 0 failed
Dry-run	deno publish --dry-run --allow-dirty	✅ Success (2 pre-existing dynamic-import warnings only)

Remaining slow-types warnings (pre-existing, not introduced by this change)

Both packages carry two expected unanalyzable-dynamic-import warnings that are by design:

• plugin-workers-core/src/runtime/job-dispatcher.ts:30 — runtime adapter bootstrap
• plugins/workers/services/src/main.ts:84 — plugin service bootstrap
• plugins/workers/src/cli/workers-cli-backend.ts:107 — CLI module loader

These dynamic imports load user-provided modules at runtime and cannot be statically analyzed. They are not slow-types blockers for JSR publishability (the publish dry-run succeeds).

Responses to Review Comments or Issue Comments

None applicable — this is a continuation of the harnessed IMPL-EVAL pass for PR #19.

Remaining Risks

1. A5 package directory name vs. naming convention: @netscript/plugin-workers lives under plugins/workers/ rather than packages/plugin-workers/. This is consistent with the Tier-2 plugin pattern used elsewhere (plugins/streams/, etc.) and does not block gates, but it can confuse archetype mapping if future harness runs expect all A5-shape packages under packages/.
2. Pre-existing dynamic imports: The three unanalyzable-dynamic-import warnings are architectural (runtime module loading). They should be tracked as accepted debt rather than re-investigated on every wave. If the JSR publish gate ever hardens to reject any dynamic-import warnings, these will need inline suppression or a refactor to static imports.
3. No e2e:cli run: The full deno task e2e:cli suite was not executed per harness guidance (“expensive; run during evaluator/merge-readiness pass or when explicitly requested”). If the merge-readiness gate requires it, it should be run in a separate session.

Run: https://github.com/rickylabs/netscript/actions/runs/27209801721

[augmentcode]

This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it.