test(cli-e2e): scaffold.runtime coverage for ui:add ai — McpUiWidget + generative-UI renderer#597
Merged
Merged
Conversation
Independent security re-attack confirms: - Depth guard complete on all 3 recursive descent paths - Type whitelist closed, no raw HTML path - Contract seam correct (consumes E4 input, existing registry) - All gates green: tests, doc-lint, publish dry-run, arch:check, lock hygiene - A1 fix verified (pre-fix bypass confirmed, post-fix guard confirmed) Co-authored-by: openhands <openhands@all-hands.dev>
rickylabs
marked this pull request as ready for review
July 10, 2026 23:34
rickylabs
added
area:cli
area:fresh-ui
epic:ai-stack
gate:e2e
priority:p1
This was referenced Jul 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
scaffold.runtimee2e coverage for the fresh-uiaicollectionui:addpath: install (scaffold.ui-add-ai), local-source dependency mapping for the unpublished@netscript/aistack (scaffold.ui-local-source), generated-workspace type-check of the copiedMcpUiWidget.tsx+render-ui.tsx(generated.ui-ai-check), and a server-render behavior gate (behavior.ui-render) asserting nested layout/viz/data output, escaped text, unknown-type and max-depth fallbacks, and absence of raw HTML.Closes #561
Closes #564
Implementation lane
WSL Codex (GPT-5.6 Sol, medium) thread
019f4e40-b1b2-7a31-a048-091559fcca4d, worktree/home/codex/repos/ns-wt-561-564, supervised by beta6-ship orchestratorfb43bc3e. Slice was implemented stacked on the #258 branch (its gate:e2e evidence) and re-merged withmainafter PR #594 landed.Validation
deno task e2e:cli run scaffold.runtime --cleanup: 54 passed / 0 failed (full one-pass suite incl. the 4 new gates)packages/cli(593 files): 0 diagnostics/findingsascasts; nodeno.lockchurnNotes
worklog-561-564.md: the generated root config needed the Fresh app's Preact precompile JSX settings for root-level copied TSX; applied in the local-source preparation gate (fixture config, not a source bypass)..llm/runs/beta6-ship--orchestrator/(worklog committed on this branch).