Skip to content

fix(ci): green main-red — stale nativeRetrial assertion + triggers fmt drift#82

Merged
rickylabs merged 1 commit into
mainfrom
fix/main-red
Jun 20, 2026
Merged

fix(ci): green main-red — stale nativeRetrial assertion + triggers fmt drift#82
rickylabs merged 1 commit into
mainfrom
fix/main-red

Conversation

@rickylabs

Copy link
Copy Markdown
Owner

Green main-red — two test-only reconciliations

main's CI was red on both lanes (surfaced via PR #81, whose only changes are CI YAML + bookkeeping). Root-caused both against the exact failures observed on Linux CI (PR #81 ci run, head 7ed56049):

Lane Linux CI result Cause Fix
check-test 660 passed | 1 failed typed-queue_test.ts asserted nativeRetrial === false for a Postgres queue, but #71 made the Postgres adapter natively retrial-capable (getNativeRetrialtrue for Postgres/Redis/RabbitMQ) flip assertion to true
quality (fmt:check) failedBatches:1, findings:1 one over-long assertStringIncludes line in trigger-runtime-processor_test.ts deno fmt wraps it

Scope

  • Test-only. No packages//plugins/ source logic changed.
  • deno.lock untouched — lock hygiene is a separate, approval-gated slice.
  • The Postgres native-retrial behaviour itself shipped in feat(queue): implement PostgreSQL queue adapter (S5) #71; this only reconciles the stale test expectation.

Local verification (Windows)

  • lint ✅, fmt:check ✅ (0 findings), check:scaffold-versions ✅ (E-12 OK), publish:dry-run ✅, audit:critical ✅ (0 critical)
  • queue test 2/2 pass; repo-wide check

Note: two scaffold/template tests fail under Windows local runs due to path-separator/CRLF artifacts (join() yields \ on Windows); both pass on Linux CI (660 passed). Not addressed here — environmental, not real.

Once green, this unblocks #81 (e2e-cli-gate rollout) to merge clean, after which scaffold-static + scaffold-runtime can be promoted to required checks.

🤖 Generated with Claude Code

…t drift

Two test-only reconciliations against the exact failures observed on Linux CI
(PR #81 ci run, head 7ed5604):

1. check-test: packages/queue/tests/typed-queue_test.ts asserted
   `nativeRetrial === false` for a Postgres queue, but #71 made the Postgres
   adapter natively retrial-capable (getNativeRetrial returns true for
   Postgres/Redis/RabbitMQ). Flip the assertion to `true`. Linux CI showed
   660 passed | 1 failed — this was the sole failure.

2. quality (fmt:check): plugins/triggers/src/runtime/trigger-runtime-processor_test.ts
   had a single over-long assertStringIncludes line; `deno fmt` wraps it.
   Sole fmt finding on Linux CI (failedBatches:1, findings:1).

No packages/plugins source logic changed. deno.lock untouched (lock hygiene is
a separate approval-gated slice). Verified locally: lint, fmt:check,
check:scaffold-versions, publish:dry-run, audit:critical all green; queue test
2/2 pass; repo-wide check green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fq9V7ujx7e1rWXi57qkPG
@rickylabs
rickylabs merged commit cf76adf into main Jun 20, 2026
4 checks passed
rickylabs added a commit that referenced this pull request Jun 21, 2026
Brings main (4 commits ahead: queue PG adapter #71, e2e-cli gate #81,
main-red nativeRetrial+fmt fix #82, agentic suite #96) up into the
prime-time umbrella ahead of #73 -> main.

Conflicts: 4 add/add files in .llm/tools/agentic/ where main's #96 was an
earlier parallel snapshot of the orchestration suite. Resolved by taking
the feat/framework-prime-time version (strict superset) for all four:
  - agentic-lib.ts      (adds resolveGithubToken durable token resolver)
  - agentic-lib_test.ts (adds PASS-WITH-NITS / kindless / menu-echo tests)
  - dispatch-openhands.ts (resolveGithubToken)
  - gh-pr.ts            (adds the merge subcommand + eval-gate flags)

Verified post-resolve: deno check EXIT 0 across all 15 agentic files;
deno test 34 passed / 0 failed; no dangling readTokenFromEnv references.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant