fix(ci): green main-red — stale nativeRetrial assertion + triggers fmt drift#82
Merged
Conversation
…t drift Two test-only reconciliations against the exact failures observed on Linux CI (PR #81 ci run, head 7ed5604): 1. check-test: packages/queue/tests/typed-queue_test.ts asserted `nativeRetrial === false` for a Postgres queue, but #71 made the Postgres adapter natively retrial-capable (getNativeRetrial returns true for Postgres/Redis/RabbitMQ). Flip the assertion to `true`. Linux CI showed 660 passed | 1 failed — this was the sole failure. 2. quality (fmt:check): plugins/triggers/src/runtime/trigger-runtime-processor_test.ts had a single over-long assertStringIncludes line; `deno fmt` wraps it. Sole fmt finding on Linux CI (failedBatches:1, findings:1). No packages/plugins source logic changed. deno.lock untouched (lock hygiene is a separate approval-gated slice). Verified locally: lint, fmt:check, check:scaffold-versions, publish:dry-run, audit:critical all green; queue test 2/2 pass; repo-wide check green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018fq9V7ujx7e1rWXi57qkPG
rickylabs
added a commit
that referenced
this pull request
Jun 21, 2026
Brings main (4 commits ahead: queue PG adapter #71, e2e-cli gate #81, main-red nativeRetrial+fmt fix #82, agentic suite #96) up into the prime-time umbrella ahead of #73 -> main. Conflicts: 4 add/add files in .llm/tools/agentic/ where main's #96 was an earlier parallel snapshot of the orchestration suite. Resolved by taking the feat/framework-prime-time version (strict superset) for all four: - agentic-lib.ts (adds resolveGithubToken durable token resolver) - agentic-lib_test.ts (adds PASS-WITH-NITS / kindless / menu-echo tests) - dispatch-openhands.ts (resolveGithubToken) - gh-pr.ts (adds the merge subcommand + eval-gate flags) Verified post-resolve: deno check EXIT 0 across all 15 agentic files; deno test 34 passed / 0 failed; no dangling readTokenFromEnv references. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Green main-red — two test-only reconciliations
main's CI was red on both lanes (surfaced via PR #81, whose only changes are CI YAML + bookkeeping). Root-caused both against the exact failures observed on Linux CI (PR #81 ci run, head7ed56049):check-test660 passed | 1 failedtyped-queue_test.tsassertednativeRetrial === falsefor a Postgres queue, but #71 made the Postgres adapter natively retrial-capable (getNativeRetrial→truefor Postgres/Redis/RabbitMQ)truequality(fmt:check)failedBatches:1, findings:1assertStringIncludesline intrigger-runtime-processor_test.tsdeno fmtwraps itScope
packages//plugins/source logic changed.deno.lockuntouched — lock hygiene is a separate, approval-gated slice.Local verification (Windows)
lint✅,fmt:check✅ (0 findings),check:scaffold-versions✅ (E-12 OK),publish:dry-run✅,audit:critical✅ (0 critical)check✅Once green, this unblocks #81 (e2e-cli-gate rollout) to merge clean, after which
scaffold-static+scaffold-runtimecan be promoted to required checks.🤖 Generated with Claude Code