Pins the family forward to its 025 releases - #46
Merged
Conversation
Moves the examples app onto the releases the operator published from campaign 025: statifier_persistence ~> 0.4, statifier_oban ~> 0.4, and the Hex arm of statifier_blocks_dep/0 ~> 0.13. statifier stays ~> 2.4 - 025 cut no new engine release - and mix.lock moves by exactly those three entries. The STATIFIER_BLOCKS_PATH escape hatch is untouched. statifier_persistence 0.4.0 is breaking for a storage adapter that encodes run_status/0 by an exhaustive match, since it gains a fourth terminal value :cancelled. StatifierExamples.Persistence delegates every status-bearing callback to the package's own Ecto adapter and matches no status itself, so it rides the library's encoding. Its moduledoc now records the other consequence of not exporting list_runs_by_metadata/2: a store on this adapter refuses a durable subchart, which this app runs none of. statifier_blocks 0.13.0 opens a stocked drafts shelf folded, so the sketch document now opens showing its flow rather than its parked work and the tray is not in the DOM until an author opens it. The two tray tests assert that opening and unfold the shelf through its own fold control rather than expecting it already open. Refs: se-t8a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The examples app is the reference embedder, so it should consume the family
from Hex at the versions that are actually published. The operator has now
published the campaign-025 releases, and this moves the app onto them.
What
statifier_persistence~> 0.3->~> 0.4statifier_oban~> 0.3.1->~> 0.4statifier_blocks~> 0.12->~> 0.13, in the Hex arm ofstatifier_blocks_dep/0only; theSTATIFIER_BLOCKS_PATHescape hatch isuntouched
statifierstays~> 2.4- campaign 025 cut no new engine releasemix.lockmoves by exactly those three entries, with no transitive driftEach version was confirmed on Hex with
mix hex.infobefore pinning. Theapp takes no
opentelemetry_statifierdep, so 0.2.0 is not in scope here.Notes
The
statifier_persistence0.4.0 breaking change is clean here. 0.4.0adds a fourth terminal
run_status/0value,:cancelled, which breaks astorage adapter that encodes statuses by an exhaustive match.
StatifierExamples.Persistenceimplements the adapter behaviour butdelegates every status-bearing callback to the package's own Ecto adapter
and matches no status itself, so it rides the library's encoding and needed
no new clause. Verified by reading the module, not by inference from a green
suite.
That module's moduledoc gains one paragraph recording the other 0.4.0
consequence of its deliberate
list_runs_by_metadata/2omission: exportingthat callback is how an adapter opts into the child listing a durable
subchart (ADR-0008) needs, so a store on this adapter refuses a durable
subchart before any write. This app runs none, and the omission is still the
right call for SQLite - but it is now a documented consequence rather than a
silent one.
statifier_blocks0.13.0 changed observable editor behaviour and twotests moved with it. A stocked drafts shelf now opens folded, so the
card_processing_sketchdocument opens showing its flow rather than itsparked work, and
.sb-slot--trayis not in the DOM until an author opensthe shelf. Rather than route around that, the two tray tests now assert the
new opening and then unfold the shelf through its own
.sb-node__foldcontrol, via a new
unfold/2test helper. What the tray holds once openedis unchanged.
Sabotage. Four mutations were run and each went red before being
reverted from a backup copy: the
statifier_blocksandstatifier_obanlock assertions pointed at their previous release lines; the
statifier_persistencerequirement pointed at its previous floor; and thenew
unfold/2call dropped from the tray test, which went red onsb-slot--trayand is what says the fold is real. The notes above each testrecord them.
The
statifier_obanguard also gains amix.lockassertion it did not havebefore - the membership check alone would have passed against a tree still
holding 0.3.1.
Gate: full
mix qualitygreen on the rebased HEAD - 244 of 244 tests,77.5% coverage, Credo and Dialyzer clean. Doctor, Sobelow and Gettext are
declared permanently inapplicable to this project.
Linkage ledger: this PR retires no ledger entries. Every
statifier_examplesentry was already resolved by PR #45; nolocalStageor
pushedStageoverride was active when this branch was cut, and none isintroduced.
Closes se-t8a