feat: SysV multi-word args and sret record returns - #104
Merged
Conversation
Classify multi-word values as stack-only; emit hidden sret pointer in rdi for records larger than 16 bytes. Extract call/return into StackMachine_Call.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
valueWords != 1) always travel on the stack; pad on word parity; callee homes advance by word count.[__sret], rax holds that pointer. Returns of 8/16 bytes use rax[+rdx].productEmitsMemoryReturnpredicate on caller and callee. Call IR carriesmemoryReturnDest/ RetrievememoryReturn.StackMachine_Call.cpp.loadWordis the single word-addressing helper (sret excludes the dest pointer).StructsReturnTestcovers Point/pair/strbuf-shaped/nested sret, register args after hidden pointer, and large pass+sret (5 6 7).Test plan
codegenTest,symbolsTest,typesTestgreenbuildworkflow (build + serial tests + coverage / Coveralls)Coveralls: 92.885% (+0.06%) from 92.829%.