sa: read enumerators from the session table - #244
Merged
Conversation
SymbolTable no longer copies session.enums. Identifier fold and file-scope clash go through LexicalSession::isEnumerator / lookupEnumerator. A missing session is an internal error.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
coverage: 94.037% (+0.004%) from 94.033% — sa/session-enum-facade into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 1.4b.
LexicalSessionis the single enumerator store.analyzeno longer copiessession.enumsintoSymbolTable. DeletedenumConstants,defineEnumConstant,hasEnumConstant,getEnumConstant, andimportParseEnumConstant.SA identifier fold and file-scope object/function clash use
session().isEnumerator/lookupEnumerator.session()throws ifsetSessionwas not called (same shape asvlaTable()). Still TU-flat. Redefinition is still diagnosed at parse. No NameTable.Tests
LexicalSession.isEnumeratorDelegatesToRegistryenterBlockSharesShadowAndObjectFramesalso asserts the enumerator survivesleaveBlockSemanticAnalyzer.missingSessionIsInternalErrorsessionEnumeratorConflictsWithFileScopeObject/fileScopeObjectWithoutSessionEnumeratorIsOkEnumsTestpins, includingenumeratorVisibleAfterDeclaringBlockandenumFileScopeObjectRedeclIsErrorGit gate
Sibling
gitclean-rebuilt withCC=trans.t/suite: 32614 success, 0 failed, 373 known breakage.Out of scope
NameTable. C-scoped enumerators (5.2).
ObjectTypeRegistry. DeletingTypedefRegistry.