sa: one ValueEntry per function; drop functions[] - #273
Merged
Conversation
File-scope functions live only in ValueScope. insertFunction writes the full Function type (including ...) and Static storage for internal linkage. FunctionEntry is a snapshot of that record. functionDefined_ is on the ValueEntry, not a parallel set. Identifier visit uses isBareFunction; the dual-table mismatch error is gone. Designator type keeps the variadic bit.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
coverage: 94.288% (+0.02%) from 94.273% — sa/one-function-value into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave D.1. One file-scope
ValueEntryper function.functions[]and thefunctionDefinedset are gone.insertFunctionwrites the fullFunctiontype (including...) andStorage::Staticif internal, elseGlobal.updateFunctionrefines that same record and keeps linkage.FunctionEntryis a snapshot (FunctionEntry(const ValueEntry&)).hasInternalLinkage()isisStatic().functionDefined_lives on theValueEntry, same pattern asdefiningInitializer.isBareFunctionis enough. Dual-table mismatch error deleted.FunctionEntrystays forFunctionFrame.getDataHomesalready skipsisFunction().Not this PR: IdentifierTable vs ValueScope (D.2).
Test plan
SymbolTable.insertFunctionValueHasVariadicAndInternalLinkageSymbolTable.updateFunctionRefinesTheSameValueAndKeepsLinkageSymbolTable.functionParameterIsPointerNotHasFunctionSymbolTable.markFunctionDefinedIsOnTheRecordSemanticAnalyzer.functionDesignatorKeepsVariadicsemantic_analyzerTest(33)