Make the CMake build target-centric and preset-driven - #59
Merged
Conversation
Replace global CMAKE_CXX_FLAGS mutation with INTERFACE libraries for includes, warnings/C++20, and optional coverage; fetch GoogleTest only when testing and pin its tarball hash. Rename the reserved codegen library target to backend, link the trans executable through driver alone, and add CMakePresets for release/debug/coverage/ci workflows.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
coverage: 91.09%. remained the same — build/cmake-idiomatic into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMAKE_CXX_FLAGS*mutation with INTERFACE targets (trans_src,trans_common,trans_coverage) andtrans_target_defaults()BUILD_TESTINGis on, withURL_HASHpinTRANS_ENABLE_COVERAGEoption (Makefile maps Debug → ON); addCMakePresets.json(default/debug/coverage/ci)codegen→backend(CMP0171 reserved name; source tree stayssrc/codegen/)transthroughdriveronly; setproject(... VERSION 0.1.0 ...)-Werrorunused variable whenassertis compiled out (StackMachine::registerFrameHome)Test plan
cmake --preset coverage(or Debug +TRANS_ENABLE_COVERAGE=ON) buildctest(18 tests) greenBUILD_TESTING=OFFbuildstranswithout fetching googletest