test: functional coverage for semantics, constants, and language surface - #60
Merged
Conversation
Add black-box SourceProgram tests for previously unexercised behavior: character-escape and unary constant folding in globals, semantic error diagnostics (arity, lvalues, voids, conflicts, arrays), default-int definitions, pointer-returning functions, multi-declarators, and clear failure contracts for unimplemented constructs.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
coverage: 92.316% (+1.2%) from 91.09% — test/functional-coverage-gaps into master |
Address review feedback: put diagnostics in a parameterized SemanticError catalog with precise message oracles, move legal language forms into LanguageSurfaceTest, collapse global constant-fold cases, drop coverage-paint tests, and sanitize SourceProgram basenames for gtest parameterized names.
The catalog restructure dropped eight covered lines in ContextualSyntaxNodeBuilder (floatType and decl_specs-only declaration). Re-add language-surface contracts that exercise those productions without reintroducing them as ExpressionTest junk.
Format PR test sources with the repo .clang-format. Extend the semantic error catalog and language surface suite with multi-type-specifiers, function-pointer declarators, invalid char-escape / non-foldable unary global inits, pointer subscript codegen rejection, and brace initializers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
ctest -L functional(all shards) passes locally