feat(codegen): array index access and multi-word array locals - #70
Merged
Conversation
Sized arrays get multi-word stack slots; IndexAddress lowers a[i]/p[i] with element stride; &a[i] reuses the element address; char stores use byte/dword widths. Functional ArraysTest covers 1D read/write, loops, pointer arrays, pointer subscript, and char arrays.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
coverage: 92.601% (+0.08%) from 92.526% — feature/array-index-mw into master |
Use movsx/movsxd so 64-bit ALU sees signed element values, and spill the index before one-operand imul so a live index in RAX is not corrupted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueScopeword packing)IndexAddressIR + StackMachine lowering fora[i]/p[i]&a[i]reuses the element address tempArraysTest(1D R/W, loops, pointer arrays, char, address-of)Stack
PR 1/N — base master. Next: array decay / multi-dim.
Test plan
ctest