phase0/03: ObjectAbi shared word/sret policy - #82
Merged
Conversation
Introduce type::object_abi (machine word, stack align, valueWords/dataWords, sret thresholds) so SA and codegen can share sizing policy. Wire StackMachine startProcedure slot counting through valueWords. Unit tests pin formulas; no sret emission yet.
- Split size-only ObjectAbi.h from Type-aware ObjectAbiType.h. - valueWords early-return style; drop unused REGISTER_RETURN_MAX_WORDS. - typeNeedsMemoryReturn uses isRecord (arrays never sret). - ValueScope::wordSlotsFor delegates to valueWords (shared SA/codegen policy). - Document current consumers; unit test large array is not sret.
- typeNeedsMemoryReturn uses isCompleteRecord. - Clarify size-threshold vs type-layer sret comments. - isAggregate comment no longer mentions sret. - Unit tests for large union sret and incomplete non-sret.
- Keep typeNeedsMemoryReturn as pure complete-record ABI need. - Rename product/variadic skip to productEmitsMemoryReturn so false never means "fits in registers" for large records under variadic. - Clarify REGISTER_RETURN_MAX_BYTES comment (complete records only).
- ValueScope nextLocalWordIndex comment references MACHINE_WORD_SIZE. - Collapse double blank line between ObjectAbi tests.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
coverage: 92.913% (+0.04%) from 92.878% — phase0/03-object-abi into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
Base:
phase0/02-type-policy→ this PR →phase0/04-symbols-leafTest plan