phase0/04: house FunctionEntry and LabelEntry in symbols leaf - #83
Merged
Conversation
Move FunctionEntry/LabelEntry implementations into symbols (host-aligned with ValueEntry). semantic_analyzer headers re-export them for existing AST/SA includes. Expand AnnotationTypes (ValueSlot/LabelSlot/FunctionFrame) and AnnotationStore label API with unit tests. Production still stores control-flow labels on AST nodes until the annotation migration.
- Slim AnnotationTypes to ValueSlot::{Result,Lvalue} and LabelSlot only
(no speculative FunctionFrame/StringSlot/extra slots).
- AnnotationStore includes LabelEntry directly after the slim.
- Non-virtual FunctionEntry destructor.
- Move labelSlots store tests into AnnotationStoreTest.
- Point codegen includes at symbols/; SA re-exports marked SA-only.
- Function::argumentCount avoids materializing argument Types. - FunctionEntry.h includes Type.h; re-export comments clarify scope. - Stronger FunctionEntry unit tests (name/type/args/context). - labelSlots overwrite + const access; clear() covers labels.
- Drop empty FunctionEntry destructor (Rule of Zero / restore moves). - Sink-move constructor parameters into members. - Pin argumentCount vs arguments().size for 0/1/3-arg FunctionEntry and Function types in unit tests.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
coverage: 92.93% (+0.02%) from 92.913% — phase0/04-symbols-leaf into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
Base:
phase0/03-object-abi→ this PR →phase0/05-annotation-migrationTest plan