phase0/05: store-backed lvalues/labels; drop ast→SA link - #84
Merged
Conversation
Move production address temps (ValueSlot::Lvalue) and control-flow labels (LabelSlot) fully onto AnnotationStore. AST nodes no longer hold LabelEntry or lvalue fields; SA writes and CG reads go through the store. Move LoggingSyntaxTreeVisitor / VerboseSyntaxTreeBuilder to driver (they need SemanticXmlOutputVisitor). ast now links only parser, types, and symbols - the host-aligned layering contract from the spike.
- Single lvalue API (setLvalueSymbol/getLvalueSymbol); drop dual names and identity overrides on ArrayAccess/MemberAccess/UnaryExpression. - SwitchStatement caseTemp on AnnotationStore (ValueSlot::CaseTemp). - Move LoggingSyntaxTreeVisitor / VerboseSyntaxTreeBuilder to namespace driver (physical package + namespace agree). - Header formatting after field removal; Lvalue comment production status.
- Drop ArrayAccess.elementSize; CG uses IndexPlan.elementSize only. - Member FieldAddress always uses Lvalue store name (no addressTemp dual). - PreOperation and Holder on AnnotationStore with convenience helpers. - CaseTemp convenience on store; unit tests for CaseTemp/PreOp/Holder. - Remove dead DirectDeclarator holder; non-virtual getLvalueSymbol; drop empty private sections.
- Drop FieldPlan/IndexPlan.addressTempName; Lvalue is sole address temp. - Remove empty private: sections left after label field removal. - Update AnnotationStore tests for plan field removal.
- Drop FunctionDesignatorPlan.addressTempName; CG uses Result as address temp. - Unify missing-slot getters to soft nullptr (Holder, PreOperation); assert at CG entry after successful SA. - Document FunctionDefinition frame residual and small node SA fields as intentional defer / optional later store migration.
Plan holds functionName only; address temp is the Result symbol.
Master's analyzeInitializedDeclarator must pass annotations() now that holders live only on the store (annotation-migration contract).
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
coverage: 92.931% (+0.001%) from 92.93% — phase0/05-annotation-migration into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setHolder.Stack
Base:
phase0/04-symbols-leaf→ this PR →phase0/06-package-graphTest plan