Skip to content

fix: render only visible row detail lines#532

Merged
riii111 merged 2 commits into
mainfrom
sab-319
Jul 16, 2026
Merged

fix: render only visible row detail lines#532
riii111 merged 2 commits into
mainfrom
sab-319

Conversation

@riii111

@riii111 riii111 commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Problem

Row Detail rendered every line before applying scroll, which made large values expensive and wrapped large vertical offsets through Ratatui's u16 scroll range.

Background

Large TEXT or JSONB values can produce more lines than the renderer's vertical offset type can represent.

Approach

Build only the visible Row Detail lines from the current scroll offset and render them without relying on Paragraph's vertical scroll offset. Add coverage for tail rendering beyond the u16 range.

@linear

linear Bot commented Jul 15, 2026

Copy link
Copy Markdown

SAB-319

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 021a85cb-4232-48c4-ab00-fbed88d1cede

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sab-319

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@riii111 riii111 self-assigned this Jul 15, 2026
@riii111
riii111 marked this pull request as ready for review July 16, 2026 00:25
@riii111
riii111 merged commit 5b25288 into main Jul 16, 2026
9 checks passed
@riii111
riii111 deleted the sab-319 branch July 16, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant