Skip to content

Surface HTTP errors from GSA auth instead of a plist parse failure #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oddharsh wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −0
Open

Surface HTTP errors from GSA auth instead of a plist parse failure #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions AltSign/Apple API/ALTAppleAPI+Authentication.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,21 @@ - (void)sendAuthenticationRequestWithParameters:(NSDictionary *)requestDictionar
return;
}

// Apple's GSA endpoint occasionally responds to this request with a plain
// HTTP error page (e.g. 503 Service Temporarily Unavailable) instead of a
// plist body. Parsing that HTML as a plist below fails with a confusing,
// low-level "unknown tag html" / kCFPropertyListOldStyleParsingError, which
// gives no indication the actual problem is a transient server error. Check
// the status code first so that case gets a clear, actionable message.
NSHTTPURLResponse *httpResponse = [response isKindOfClass:[NSHTTPURLResponse class]] ? (NSHTTPURLResponse *)response : nil;
if (httpResponse != nil && (httpResponse.statusCode < 200 || httpResponse.statusCode >= 300))
{
NSString *localizedDescription = [NSString stringWithFormat:@"Apple's servers returned an error while authenticating (HTTP %@). Please try again later.", @(httpResponse.statusCode)];
NSError *error = [NSError errorWithDomain:ALTAppleAPIErrorDomain code:ALTAppleAPIErrorUnknown userInfo:@{NSLocalizedDescriptionKey: localizedDescription}];
completionHandler(nil, error);
return;
}

NSError *parseError = nil;
NSDictionary *responseDictionary = [NSPropertyListSerialization propertyListWithData:data options:0 format:nil error:&parseError];

Expand Down