Skip to content

Server error codes audit - #9277

Merged
begelundmuller merged 4 commits into
mainfrom
begelundmuller/rpc-errors
Apr 24, 2026
Merged

Server error codes audit#9277
begelundmuller merged 4 commits into
mainfrom
begelundmuller/rpc-errors

Conversation

@begelundmuller

@begelundmuller begelundmuller commented Apr 22, 2026

Copy link
Copy Markdown
Contributor
  • Consistently differentiate between not found and forbidden errors
  • Defer status code mapping to error handling middleware when possible
  • Audit server error handling for consistency and correctness

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@begelundmuller begelundmuller self-assigned this Apr 22, 2026
Comment thread admin/server/alerts.go
Comment thread admin/server/alerts.go
Comment thread admin/server/alerts.go
Comment thread admin/server/deployment.go
Comment thread admin/server/deployment.go
Comment thread runtime/server/repos.go
Comment thread runtime/server/repos.go
Comment thread runtime/server/repos.go
Comment thread runtime/server/templated_strings.go
Comment thread runtime/server/server.go Outdated
@begelundmuller
begelundmuller requested a review from pjain1 April 23, 2026 13:41

@pjain1 pjain1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried checking but looks like no logic depends on the returned status codes, as long as its the case this looks fine.

@begelundmuller
begelundmuller merged commit 39d3706 into main Apr 24, 2026
14 of 15 checks passed
@begelundmuller
begelundmuller deleted the begelundmuller/rpc-errors branch April 24, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants