Don't exit analyst agent pre-invocation on non-context errors#9482
Merged
begelundmuller merged 2 commits intoMay 22, 2026
Merged
Conversation
k-anshul
approved these changes
May 21, 2026
| MetricsView: mvName, | ||
| }) | ||
| if err != nil { | ||
| if err != nil && errors.Is(err, ctx.Err()) { // Don't exit on non-context errors |
Member
There was a problem hiding this comment.
GetMetricsViewName seems like an essential tool call and if that fails, maybe the agent should fail ?
If not, then we should not also fail on the GetCanvasName done just above this ?
Collaborator
There was a problem hiding this comment.
won't the agent have the opportunity to retry ?
nishantmonu51
approved these changes
May 21, 2026
begelundmuller
deleted the
begelundmuller/analyst-agent-ignore-non-context-errors
branch
begelundmuller
added a commit
that referenced
this pull request
May 22, 2026
* Don't exit analyst agent pre-invocation on non-context errors * Review
begelundmuller
added a commit
that referenced
this pull request
May 22, 2026
* Don't exit analyst agent pre-invocation on non-context errors * Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.