Skip to content

Don't exit analyst agent pre-invocation on non-context errors #9482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
begelundmuller merged 2 commits into from
May 22, 2026
+5 −4
Merged

Don't exit analyst agent pre-invocation on non-context errors #9482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e196731
Don't exit analyst agent pre-invocation on non-context errors
begelundmuller May 21, 2026
be790ad
Review
begelundmuller May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions runtime/ai/analyst_agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package ai

import (
"context"
"errors"
"fmt"
"strings"
"time"
Expand Down Expand Up @@ -119,7 +120,7 @@ func (t *AnalystAgent) Handler(ctx context.Context, args *AnalystAgentArgs) (*An
_, err := s.CallTool(ctx, RoleAssistant, GetCanvasName, nil, &GetCanvasArgs{
Canvas: args.Canvas,
})
if err != nil {
if err != nil && errors.Is(err, ctx.Err()) { // Don't exit on non-context errors
return nil, err
}

Expand All @@ -138,14 +139,14 @@ func (t *AnalystAgent) Handler(ctx context.Context, args *AnalystAgentArgs) (*An
_, err := s.CallTool(ctx, RoleAssistant, QueryMetricsViewSummaryName, nil, &QueryMetricsViewSummaryArgs{
MetricsView: mvName,
})
if err != nil {
if err != nil && errors.Is(err, ctx.Err()) { // Don't exit on non-context errors
return nil, err
}

_, err = s.CallTool(ctx, RoleAssistant, GetMetricsViewName, nil, &GetMetricsViewArgs{
MetricsView: mvName,
})
if err != nil {
if err != nil && errors.Is(err, ctx.Err()) { // Don't exit on non-context errors
Copy link
Copy Markdown
Member

@k-anshul k-anshul May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetMetricsViewName seems like an essential tool call and if that fails, maybe the agent should fail ?

If not, then we should not also fail on the GetCanvasName done just above this ?

Copy link
Copy Markdown
Collaborator

@nishantmonu51 nishantmonu51 May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't the agent have the opportunity to retry ?

return nil, err
}
}
Expand All @@ -154,7 +155,7 @@ func (t *AnalystAgent) Handler(ctx context.Context, args *AnalystAgentArgs) (*An
// If no specific dashboard is being explored, we pre-invoke the list_metrics_views tool.
if first && len(metricsViewNames) == 0 {
_, err := s.CallTool(ctx, RoleAssistant, ListMetricsViewsName, nil, &ListMetricsViewsArgs{})
if err != nil {
if err != nil && errors.Is(err, ctx.Err()) { // Don't exit on non-context errors
return nil, err
}
}
Expand Down
Loading